Align configurations of black and isort. #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 75 75
Lines 1990 1990
=======================================
Hits 1817 1817
Misses 173 173
Continue to review full report at Codecov.
|
saratvemulapalli
approved these changes
Oct 20, 2021
1 task
gaiksaya
reviewed
Oct 20, 2021
|
|
||
| [tool.isort] | ||
| profile = "black" | ||
| line_length = 160 |
There was a problem hiding this comment.
What is the difference between line 7 and line 2
There was a problem hiding this comment.
They apply to two different tools (isort vs. black).
VachaShah
approved these changes
Oct 20, 2021
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
Adds a pyproject.toml with black and isort configurations aligned, and on the same line length as flake8. With this change one does not attempt to auto-correct the other. Ran the auto-formatter on all of the source once which is all the other changes.
Extracted from #767.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.