Skip to content

Enable components to declare compatible platforms. #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 27, 2021

Signed-off-by: dblock [email protected]

Description

  • Enable components to declare compatible platforms, defaults to all.
  • Exclude incompatible components during build.
  • Raise an error if no components match, e.g. if one specifies --component=invalid.

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from mch2 October 27, 2021 14:42
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish there was an easy way to hide the refactoring as you went as a separate PR. Is there another styling tool you'd prefer we pick up?

(Note; I am happy with the refactoring's that I do see and would prefer this updated format)

@@ -54,6 +54,9 @@ components:
checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version
platforms:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be changing manifest schema version of all manifests that consist of this change?

Copy link
Member Author

@dblock dblock Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old manifests comply with this schema, but we would increment the version if there was older code reading newer manifests. Since this repo is the only place where we currently read these manifests, we don't have to.

@dblock dblock merged commit fba6709 into opensearch-project:main Oct 27, 2021
@dblock dblock deleted the select-platform branch October 27, 2021 19:08
@dblock dblock mentioned this pull request Nov 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add platform selection into components Build/sign and other run_ workflows skipping components should fail if the component doesn't exist
3 participants