Skip to content

[Backport 2.x] ism-plugin: fix tests #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 10443bd from #1030

Change ...

  1. 'Close indices' to 'Close'
  2. 'Open indices' to 'Open'
  3. 'indices' to 'indexes'
  4. Sample slack webhook to meet current validation

... to match current tech writing guidelines.

Signed-off-by: Rohit Ashiwal <[email protected]>
(cherry picked from commit 10443bd)
@Hailong-am
Copy link
Collaborator

@r1walz DCO check failed, can you check you github email address matches with local git config email address?

@r1walz
Copy link
Contributor

r1walz commented Feb 1, 2024

Hi, @Hailong-am. I see that DCO sign-off by github bot is not included in the commit msg:

Change ...

  1. 'Close indices' to 'Close'
  2. 'Open indices' to 'Open'
  3. 'indices' to 'indexes'
  4. Sample slack webhook to meet current validation

... to match current tech writing guidelines.

Signed-off-by: Rohit Ashiwal <[email protected]>
(cherry picked from commit https://github.com/opensearch-project/opensearch-dashboards-functional-test/commit/10443bddc26164d8cf24878746fe47897f060c79)
// missing github bot sign-off

It's usually present like this: opensearch-project/OpenSearch#12115

[Backport 2.x] Add additional logging for Azure repository stats

* Adding logging for AzureStats

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Debugging

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing debugging lines

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Addressing comments

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Addressing feedback 2

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit https://github.com/opensearch-project/OpenSearch/commit/16c52577d4f9a2544614d119e0cb6c6fc0d2afa5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>  <--- here

@r1walz
Copy link
Contributor

r1walz commented Feb 1, 2024

Should I open a new backport PR?

@Hailong-am
Copy link
Collaborator

Should I open a new backport PR?

yes, thanks

@r1walz
Copy link
Contributor

r1walz commented Feb 1, 2024

Please, close this in favor of #1034. Thanks.

@Hailong-am Hailong-am closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants