Fix bug of missing some OIDC config #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this.config.openid?.root_ca) { | ||
| wreckHttpsOption.ca = [fs.readFileSync(this.config.openid.root_ca)]; | ||
| } | ||
| if (this.config.openid?.verify_hostnames === false) { |
There was a problem hiding this comment.
Do we need to handle if this.config.openid?.verify_hostnames is undefined?
There was a problem hiding this comment.
not necessary, because this.config.openid will definitely be an object because this is OpenID auth, and verify_hostnames has default value of true
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 85 85
Lines 1842 1842
Branches 237 237
=======================================
Hits 1374 1374
Misses 413 413
Partials 55 55 Continue to review full report at Codecov.
|
yuxitang-amzn
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #569
Description of changes: Fix the bug where OIDC connection config was not used. Now users can configure the root CA and whether to verify hostnames when connecting to OIDC server
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.