Skip to content

Conversation

@adobes1
Copy link

@adobes1 adobes1 commented Dec 11, 2025

Hermetic builds require that running go mod vendor produces no diff. Without this PR, ART can't build ose-ibmcloud-cluster-api-controllers hermetically.

The changes in this PR are the result of running go mod vendor and ensuring that the vendored file is commited and not ignored by .gitignore

@openshift-ci openshift-ci bot requested review from racheljpg and sub-mod December 11, 2025 12:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@adobes1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prb112
Copy link
Contributor

prb112 commented Dec 11, 2025

Hey @adobes1 when ready please assign @Karthik-K-N for review.

@adobes1 adobes1 changed the title [release-4.18] Fix incomplete vendor/ OCPBUGS-67286: [release-4.18] Fix incomplete vendor/ Dec 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025
@openshift-ci-robot
Copy link

@adobes1: This pull request references Jira Issue OCPBUGS-67286, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-67285 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Hermetic builds require that running go mod vendor produces no diff. Without this PR, ART can't build ose-ibmcloud-cluster-api-controllers hermetically.

The changes in this PR are the result of running go mod vendor and ensuring that the vendored file is commited and not ignored by .gitignore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adobes1
Copy link
Author

adobes1 commented Dec 12, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025
@openshift-ci-robot
Copy link

@adobes1: This pull request references Jira Issue OCPBUGS-67286, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-67285 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-67285 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 December 12, 2025 09:18
@adobes1
Copy link
Author

adobes1 commented Dec 12, 2025

/assign Karthik-K-N

@Karthik-K-N
Copy link
Member

@adobes1 Thanks for the PR, I know its already been fixed in the main/recent branches via PR #112

Does it need to be added for all the other branches, because I dont this we support till 4.12.
/cc @RadekManak

@openshift-ci openshift-ci bot requested a review from RadekManak December 15, 2025 04:59
@adobes1
Copy link
Author

adobes1 commented Dec 15, 2025

Hi @Karthik-K-N! OCP has an exception for being non-hermetic which expires on January 30th, 2026. Since 4.12 goes EOL on January 17, 2026, we should be able to skip that. I'm not too sure about 4.13 since that is a bit of a special case but I will ask around for clarification.

We need to get this fix in for all the other versions (4.14 to 4.18) since ose-ibmcloud-cluster-api-controllers will continue to be shipped in those versions

Copy link
Member

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Karthik-K-N
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunzhaohua2
Copy link

/verified by @sunzhaohua2

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 16, 2025
@openshift-ci-robot
Copy link

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

Details

In response to this:

/verified by @sunzhaohua2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants