-
Notifications
You must be signed in to change notification settings - Fork 25
OCPBUGS-67286: [release-4.18] Fix incomplete vendor/ #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.18
Are you sure you want to change the base?
Conversation
|
@adobes1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hey @adobes1 when ready please assign @Karthik-K-N for review. |
|
@adobes1: This pull request references Jira Issue OCPBUGS-67286, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@adobes1: This pull request references Jira Issue OCPBUGS-67286, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign Karthik-K-N |
|
@adobes1 Thanks for the PR, I know its already been fixed in the main/recent branches via PR #112 Does it need to be added for all the other branches, because I dont this we support till 4.12. |
|
Hi @Karthik-K-N! OCP has an exception for being non-hermetic which expires on January 30th, 2026. Since 4.12 goes EOL on January 17, 2026, we should be able to skip that. I'm not too sure about 4.13 since that is a bit of a special case but I will ask around for clarification. We need to get this fix in for all the other versions (4.14 to 4.18) since |
Karthik-K-N
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Karthik-K-N The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/verified by @sunzhaohua2 |
|
@sunzhaohua2: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hermetic builds require that running
go mod vendorproduces no diff. Without this PR, ART can't build ose-ibmcloud-cluster-api-controllers hermetically.The changes in this PR are the result of running
go mod vendorand ensuring that the vendored file is commited and not ignored by.gitignore