[WIP][NE-2131] OTE - Implement initial framework and tests #1284
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| specs = specs.Walk(func(spec *et.ExtensionTestSpec) { | ||
| spec.Name = spec.Name + " using OTE" | ||
| }) |
There was a problem hiding this comment.
Remove, was just added to flag the test and show on openshift/origin execution
|
One extra step to validate: once this is merged, we can add the ext tests as an additional suite: https://github.com/openshift/operator-framework-operator-controller/tree/main/openshift/tests-extension#e2e-test-configuration This should be carefully considered as it can add some extra burden on the e2e (a new environment creation), or we can check with OTE team if we can append these tests to our own already existing e2e tests Also we need to add some extra validation steps for the generated metadata, eg: https://github.com/openshift/release/blob/6fa0aed23caebc291168b2ef829832ba5f1d4b2b/ci-operator/config/openshift/operator-framework-operator-controller/openshift-operator-framework-operator-controller-main.yaml#L169C1-L178C29 |
| "github.com/openshift/cluster-ingress-operator/test/extended/framework" | ||
| ) | ||
|
|
||
| var _ = g.Describe("[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io]", func() { |
There was a problem hiding this comment.
| var _ = g.Describe("[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io]", func() { | |
| var _ = g.Describe("[sig-network-edge][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io]", func() { |
Better to keep consistent with the "GatewayAPIController" tests.
I used wrong tag when adding tests to Origin repo before.
| The test files contained on this directory will be executed as part of openshift/origin | ||
| extended tests. | ||
|
|
||
| Some of the tests on this directory were originally migrated from openshift/origin/test/extended/router |
There was a problem hiding this comment.
QE also want to migrate tests from openshift/openshift-tests-private/test/extended/router to component repo, could we migrate to this specs directory ?
|
@rikatz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change implements the OTE (Openshift Tests Extension) on Cluster Ingress Operator, and migrates 2 tests suites to it:
As the tests were originally based on openshift/origin, a part of the framework had to be migrated/adapted to the new approach. This was necessary to avoid importing the whole openshift/origin and kubernetes/kubernetes tree just for test helper functions.
There is still pending work: