Bug 2001617: Disallow forward jumps for BucketClass Flow

[rexagod]

Disallow forward jumps in the BucketClass Wizard navigation sidebar so
as to make sure that the user does not go any further than they are
supposed to without completing the previous steps first.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@rexagod: This pull request references Bugzilla bug 2001617, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2001617: Disallow forward jumps for BucketClass Flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rexagod]

/bugzilla refresh

[openshift-ci]

@rexagod: This pull request references Bugzilla bug 2001617, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rexagod]

/test frontend

[rexagod]

/test ceph-storage-plugin

[bipuladh]

Suggested change

	const idIndexPlusOne = Object.values(CreateStepsBC).indexOf(CreateStepsBC[id]) + 1;
	const newStepHigherBound =
	stepHigherBound < idIndexPlusOne ? idIndexPlusOne : stepHigherBound;
	setStepHigherBound(newStepHigherBound);
	}}
	setStepsReached(StepIndexMap[id]);

If id is the upcoming step then we might have to add some guard for corner cases.

[rexagod]

I just tested out the changes and it seems to work well. I think we are good here since onNext will only be called for n-1 steps and onSave will be called for the last one.

[rexagod]

Pushing changes for https://bugzilla.redhat.com/show_bug.cgi?id=2001617#c1 in a bit. Pushed.

[rexagod]

[rexagod]

/retest
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console/10001/pull-ci-openshift-console-master-ceph-storage-plugin/1438786612401016832#1:build-log.txt%3A47

[bipuladh]

/test frontend

[bipuladh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/ceph-storage-plugin/OWNERS [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rexagod: All pull requests linked via external trackers have merged:

• openshift/console#10001

Bugzilla bug 2001617 has been moved to the MODIFIED state.

In response to this:

Bug 2001617: Disallow forward jumps for BucketClass Flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.