Bug 2002133: add support/virtualization and improve deleteResource #10003

gouyang · 2021-09-07T08:29:56Z

Note for review：

introduce support/virtualization
improve deleteResource, make it a oneline function
fix flaky while pause a VM

openshift-ci · 2021-09-08T04:40:48Z

@gouyang: This pull request references Bugzilla bug 2002133, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002133: add support/virtualization and improve deleteResource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-08T04:40:49Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2002133, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.10.0) matches configured target release for branch (4.10.0)

bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002133: add support/virtualization and improve deleteResource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2021-09-08T06:19:47Z

/retest

gouyang · 2021-09-08T09:07:28Z

/retest

gouyang · 2021-09-08T10:27:58Z

/retest

openshift-ci · 2021-09-08T10:33:07Z

@gouyang: This pull request references Bugzilla bug 2002133, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002133: add support/virtualization and improve deleteResource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-08T10:33:08Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2002133, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target release (4.10.0) matches configured target release for branch (4.10.0)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002133: add support/virtualization and improve deleteResource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouyang · 2021-09-08T10:33:29Z

@pcbailey @yaacov PTAL, thanks.

pcbailey · 2021-09-08T19:03:55Z

.../kubevirt-plugin/integration-tests-cypress/tests/vm-template/custom-template-support.spec.ts

Does this remove the PVC as well?

yes, PVC is deleted along with DV.

pcbailey · 2021-09-08T19:06:07Z

frontend/packages/kubevirt-plugin/integration-tests-cypress/utils/const/index.ts

I know this isn't really a part of this PR, but could you please rename this to 'DEFAULT_VALUES'?

Sure, will change the name.

pcbailey · 2021-09-08T19:07:30Z

frontend/packages/kubevirt-plugin/integration-tests-cypress/utils/const/index.ts

nitpick: K8SKIND => K8S_KINDS

How about just use K8S_KIND?

That works! Both singular and plural names are used for enums throughout the codebase, but I think you're right that it should be singular.

pcbailey · 2021-09-08T19:09:56Z

frontend/packages/kubevirt-plugin/integration-tests-cypress/support/index.ts

I thought we had a scenario where we'd get an error if we didn't pass false for the ignore-not-found flag? I didn't see any instances where we were passing false, but I wanted to double check with you.

yes, I removed the ignoreNotFound = true in the parameters because there isn't any instance pass false to this function.
If there is such scenario, let's add it back by then.

pcbailey · 2021-09-08T19:16:58Z

frontend/packages/kubevirt-plugin/integration-tests-cypress/support/virtualization.ts

I like this idea! My only concern is around naming. We're going to be adding the Virtualization Overview page soon and moving the VMs and Templates pages to their own dedicated pages instead of tabs, so this won't work anymore since there won't be an actual Virtualization page that defaults to the VMs list. What do you think about the following?

visitVirtualizationOverview (when it's added)

visitVMsList

visitVMTemplatesList

visitVMsList and visitVMTemplatesList looks better, will change the name.

yaacov · 2021-09-09T06:56:55Z

/retest

pcbailey · 2021-09-09T11:02:36Z

/test e2e-gcp-console

pcbailey · 2021-09-09T12:11:40Z

/test e2e-gcp-console

pcbailey · 2021-09-09T13:20:46Z

/lgtm

openshift-ci · 2021-09-09T13:21:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-09-09T17:05:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-09T18:26:20Z

@gouyang: All pull requests linked via external trackers have merged:

openshift/console#10003

Bugzilla bug 2002133 has been moved to the MODIFIED state.

In response to this:

Bug 2002133: add support/virtualization and improve deleteResource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from pcbailey and rhrazdil September 7, 2021 08:30

openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 7, 2021

gouyang force-pushed the improve_support branch 2 times, most recently from 5c07eec to d64ac89 Compare September 8, 2021 04:33

gouyang changed the title ~~add support/virtualization~~ add support/virtualization and improve deleteSource Sep 8, 2021

gouyang changed the title ~~add support/virtualization and improve deleteSource~~ add support/virtualization and improve deleteResource Sep 8, 2021

gouyang force-pushed the improve_support branch 2 times, most recently from 95e2d05 to 757ba44 Compare September 8, 2021 04:38

gouyang changed the title ~~add support/virtualization and improve deleteResource~~ Bug 2002133: add support/virtualization and improve deleteResource Sep 8, 2021

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 8, 2021

gouyang force-pushed the improve_support branch from 757ba44 to 224f3f8 Compare September 8, 2021 08:01

pcbailey suggested changes Sep 8, 2021

View reviewed changes

gouyang force-pushed the improve_support branch 3 times, most recently from 0fd5d48 to bd13996 Compare September 9, 2021 02:25

gouyang force-pushed the improve_support branch 2 times, most recently from 50b43b7 to 8dcce7a Compare September 9, 2021 08:47

add support/virtualization and improve deleteResource

2835476

gouyang force-pushed the improve_support branch from 8dcce7a to 2835476 Compare September 9, 2021 09:03

openshift-ci bot assigned pcbailey Sep 9, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021

openshift-merge-robot merged commit f0f847c into openshift:master Sep 9, 2021

spadgett added this to the v4.10 milestone Sep 23, 2021

Bug 2002133: add support/virtualization and improve deleteResource #10003

Bug 2002133: add support/virtualization and improve deleteResource #10003

Uh oh!

Conversation

gouyang commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

gouyang commented Sep 8, 2021

Uh oh!

gouyang commented Sep 8, 2021

Uh oh!

gouyang commented Sep 8, 2021

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

openshift-ci bot commented Sep 8, 2021

Uh oh!

gouyang commented Sep 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gouyang Sep 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yaacov commented Sep 9, 2021

Uh oh!

pcbailey commented Sep 9, 2021

Uh oh!

pcbailey commented Sep 9, 2021

Uh oh!

pcbailey commented Sep 9, 2021

Uh oh!

openshift-ci bot commented Sep 9, 2021

Uh oh!

openshift-bot commented Sep 9, 2021

Uh oh!

openshift-ci bot commented Sep 9, 2021

Uh oh!

Uh oh!

gouyang commented Sep 7, 2021 •

edited

Loading

gouyang Sep 8, 2021 •

edited

Loading