Bug 2001804: Reload feature on Environment section in Build Config form does not work properly

[yozaam]

Fixes:

https://issues.redhat.com/browse/ODC-6300

Analysis / Root cause:

https://issues.redhat.com/browse/ODC-6300?focusedCommentId=18891580&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18891580

As mentioned here -> the local state is not getting updated with the env values coming from reload ( from formData )

Solution Description:

added hook to set local state when the envs prop changes

Screen shots / Gifs for design review:

Unit test coverage report:

Test setup:

Steps to Reproduce

1. Create a devfile
2. Go to build tab -> Edit BuilldConfig form
3. Add a config map "devfile-sample-1-ca" in the environment section and save it
4. Switch to YAML view and change the config map to "devfile-sample-1-global-ca"
5. Return to Form view and click on Reload button

• Expected results:
  • Config map should be restored to "devfile-sample-1-ca"

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

@yozaam: This pull request references Bugzilla bug 2001804, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2001804: Reload feature on Environment section in Build Config form does not work properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yozaam]

/cc @nemesis09

[yozaam]

/retest-required

[nemesis09]

/retest

[nemesis09]

/retest

[nemesis09]

/retest

[yozaam]

/retest

[yozaam]

/retest

[nemesis09]

/lgtm

[invincibleJai]

@yozaam I see one issue with the configMap key not getting persisted in form view. PTAL at the attached gif

[invincibleJai]

i think we memoize it and use environmentVariables directly in useEffect as well

Suggested change

	const environmentVariables = getEnvironmentVariables(envs);
	const environmentVariables = React.useMemo(() => {
	return !_.isEmpty(envs) ? envs.map((env) => _.values(env)) : [['', '']];
	},[envs])

[yozaam]

alright, trying it now

regarding configMap key, can I make a new issue ?
when we select the key on latest master branch also it doesn't appear

[invincibleJai]

yeah, we can log a new one for that.

[yozaam]

I believe the issue was caused because a prop had the name key which is reserved by React
changed the prop to pairKey

[debsmita1]

tried this out locally
/lgtm

[invincibleJai]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, invincibleJai, nemesis09, yozaam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@yozaam: All pull requests linked via external trackers have merged:

• openshift/console#10004

Bugzilla bug 2001804 has been moved to the MODIFIED state.

In response to this:

Bug 2001804: Reload feature on Environment section in Build Config form does not work properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.