Skip to content

Bug 2001959: Allow side nav borders to extend to left and right edges of yaml sidebar #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

Bug 2001959: Allow side nav borders to extend to left and right edges of yaml sidebar #10009

merged 1 commit into from
Sep 7, 2021

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 7, 2021

This regression was introduced with #9532

before
Screen Shot 2021-09-07 at 10 21 17 AM

after
Screen Shot 2021-09-07 at 10 19 22 AM

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@sg00dwin: This pull request references Bugzilla bug 2001959, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2001959: Allow side nav borders to extend to left and right edges of yaml sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from yapei, jhadvig and spadgett September 7, 2021 14:45
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Sep 7, 2021
spadgett
spadgett approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

spadgett commented Sep 7, 2021

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit bc00f6d into openshift:master Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@sg00dwin: All pull requests linked via external trackers have merged:

Bugzilla bug 2001959 has been moved to the MODIFIED state.

In response to this:

Bug 2001959: Allow side nav borders to extend to left and right edges of yaml sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 7, 2021
Merged
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #10011

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the yaml-sidebar-nav-margin-defect branch September 10, 2021 15:02
@XiyunZhao
Copy link

/lgtm

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@yapei yapei Awaiting requested review from yapei

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
6 participants
@sg00dwin @spadgett @openshift-cherrypick-robot @XiyunZhao @TheRealJon @openshift-merge-robot