Bug 2002027: Use exact secret label match when creating HelmRelease topology node model #10012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-6293
Analysis / Root cause:
When creating the HelmRelease topology node model, the associated secret is selected by matching a subset of it's label(using
str.includes()
) with the release name. This led to selecting the incorrect secret when there are releases sharing a common substring of the name.Solution Description:
Match the exact string of the release name with the label when selecting the secret.
Unit test coverage report:
(Unchanged)
Browser conformance:
/kind bug