Skip to content

Bug 2002134: add test to verify vm details tab #10017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

Bug 2002134: add test to verify vm details tab #10017

merged 1 commit into from
Sep 8, 2021

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Sep 8, 2021

No description provided.

@openshift-ci openshift-ci bot requested review from glekner and mareklibra September 8, 2021 01:32
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 8, 2021
@gouyang gouyang force-pushed the vm_details_tab branch 3 times, most recently from c9a4a2a to 0dad6ee Compare September 8, 2021 03:05
@gouyang gouyang changed the title Vm details tab add test to verify vm details tab Sep 8, 2021
@gouyang gouyang changed the title add test to verify vm details tab Bug 2002134: add test to verify vm details tab Sep 8, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@gouyang: This pull request references Bugzilla bug 2002134, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002134: add test to verify vm details tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2002134, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2002134: add test to verify vm details tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

pcbailey
pcbailey reviewed Sep 8, 2021
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests-cypress/utils/const/errorString.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: These constants should use the constants naming convention (ERROR_OCCURRED).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, updated.

@pcbailey
Copy link
Contributor

pcbailey commented Sep 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit fc5cd7b into openshift:master Sep 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2021

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 2002134 has been moved to the MODIFIED state.

In response to this:

Bug 2002134: add test to verify vm details tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner Awaiting requested review from glekner

@mareklibra mareklibra Awaiting requested review from mareklibra

1 more reviewer

@pcbailey pcbailey pcbailey left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
4 participants
@gouyang @pcbailey @spadgett @openshift-merge-robot