Skip to content

OCPBUGS-60969: Console headers are empty when used from a dynamic plugin #15439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+27 −12
Closed

OCPBUGS-60969: Console headers are empty when used from a dynamic plugin #15439

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e9aced
fix: Refactor getConsoleRequestHeaders to check store availability be…
Leo6Leo Aug 27, 2025
cc32506
Merge remote-tracking branch 'upstream' into lepo/ocpbugs/60779/empty…
Leo6Leo Sep 4, 2025
9a32ca7
fix: use the global store to avoid the race condition
Leo6Leo Sep 4, 2025
04696de
cherry-pick: apply gabriel's commit
Leo6Leo Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions frontend/packages/console-dynamic-plugin-sdk/src/utils/fetch/console-fetch-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,23 @@ export const getCSRFToken = () => {
*/
export const getConsoleRequestHeaders = (): ConsoleRequestHeaders => {
const store = storeHandler.getStore();
if (!store) return undefined;
const state = store.getState();

const headers: ConsoleRequestHeaders = {
'X-CSRFToken': getCSRFToken(),
};

// Set impersonation headers
const { kind, name } = getImpersonate(state) || {};
if ((kind === 'User' || kind === 'Group') && name) {
// Even if we are impersonating a group, we still need to set Impersonate-User to something or k8s will complain
headers['Impersonate-User'] = name;
if (kind === 'Group') {
headers['Impersonate-Group'] = name;
// If store is available, add impersonation headers
if (store) {
const state = store.getState();

// Set impersonation headers
const { kind, name } = getImpersonate(state) || {};
if ((kind === 'User' || kind === 'Group') && name) {
// Even if we are impersonating a group, we still need to set Impersonate-User to something or k8s will complain
headers['Impersonate-User'] = name;
if (kind === 'Group') {
headers['Impersonate-Group'] = name;
}
}
}

Expand Down