Skip to content

CONSOLE-4772: Update list pages to use DataView in Workloads Tab #15489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CONSOLE-4772: Update list pages to use DataView in Workloads Tab #15489

wants to merge 9 commits into from

Conversation

krishagarwal278
Copy link
Member

@krishagarwal278 krishagarwal278 commented Sep 12, 2025 •
edited
Loading

Updated CRD list pages(secret, deployment, deployment-config, daemon-set, PDB, configmap) in workloads

workloads.1.mp4

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Modified the Secrets.jsx
https://github.com/user-attachments/assets/4c298b8d-6953-483c-be8c-08f2834c5932

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing labels Sep 12, 2025
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
frontend/public/components/secret.jsx Outdated
</>
);
const rowCells = {
name: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deduplicate the keys by pulling them out to a separate array of objects.

rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Modified Secrets.jsx

488963068-4c298b8d-6953-483c-be8c-08f2834c5932.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
rhamilto
rhamilto reviewed Sep 12, 2025
View reviewed changes
@krishagarwal278 krishagarwal278 changed the title CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab [WIP] CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab Sep 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2025
@krishagarwal278
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025
@krishagarwal278 krishagarwal278 changed the title [WIP] CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab Sep 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@krishagarwal278 krishagarwal278 changed the title CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab [WIP] CONSOLE-4772: Update CRD list pages to use DataView in Workloads Tab Sep 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@krishagarwal278 krishagarwal278 force-pushed the CONSOLE-4772 branch 2 times, most recently from afacb45 to 66c1116 Compare September 17, 2025 23:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Updated CRD list pages(secret, deployment, deployment-config, configmap) in workloads

workloads.1.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@krishagarwal278
Copy link
Member Author

qe-approval:
/assign @yapei
/verified later @yapei

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 1, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This PR has been marked to be verified later by @yapei.

In response to this:

qe-approval:
/assign @yapei
/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jseseCCS, krishagarwal278, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krishagarwal278
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0a2f026 and 2 for PR HEAD a937bbe in total

@rhamilto
Copy link
Member

rhamilto commented Oct 2, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

In response to this:

Updated CRD list pages(secret, deployment, deployment-config, daemon-set, configmap) in workloads

workloads.1.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4772 which is a valid jira issue.

In response to this:

Updated CRD list pages(secret, deployment, deployment-config, daemon-set, PDB, configmap) in workloads

workloads.1.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d62c016 and 1 for PR HEAD a937bbe in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1e64b1f and 0 for PR HEAD a937bbe in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision a937bbe was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 6, 2025

/retest
The error log says failing pulling the image, so it might be a network issue

@krishagarwal278
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2f4e6a3 and 2 for PR HEAD a937bbe in total

rhamilto added a commit to rhamilto/console that referenced this pull request Oct 6, 2025
@rhamilto
Fixes from openshift#15489
c3b2229
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD db50c8f and 1 for PR HEAD a937bbe in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD aaaa07d and 0 for PR HEAD a937bbe in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a937bbe link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-console a937bbe link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision a937bbe was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@TheRealJon TheRealJon TheRealJon approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

+2 more reviewers

@logonoff logonoff logonoff left review comments

@jseseCCS jseseCCS jseseCCS approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sferich888 sferich888

@yanpzhan yanpzhan

@yapei yapei

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. verified Signifies that the PR passed pre-merge verification criteria verified-later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.