Skip to content

OCPBUGS-61937: Add Missing Periods to Error Messages and update try again button link #15511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

OCPBUGS-61937: Add Missing Periods to Error Messages and update try again button link #15511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f065253
fix(error.tsx): add missing periods to error messages and update logo…
Leo6Leo Sep 17, 2025
2fa22ed
fix: run i18n
Leo6Leo Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/public/components/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ const LoginErrorMessage: React.FC = () => {
case 'login_state_error':
return t('public~There was an error generating login state.');
case 'cookie_error':
return t('public~There was an error setting login state cookie');
return t('public~There was an error setting login state cookie.');
case 'logout_error':
return t('public~There was an error logging you out. Please try again.');
case 'auth':
// When the error type is set as auth
switch (error) {
case 'missing_state':
return t('public~There was an error parsing your state cookie');
return t('public~There was an error parsing your state cookie.');
case 'invalid_state':
return t(
'public~There was an error verifying your session. Please log out and try again.',
Expand Down Expand Up @@ -148,7 +148,7 @@ export const AuthenticationErrorPage: React.FC = () => {
</Stack>
}
customFooter={
<ButtonLink variant="primary" href="/logout">
<ButtonLink variant="primary" href="/">
{t('public~Try again')}
</ButtonLink>
}
Expand Down
4 changes: 2 additions & 2 deletions frontend/public/locales/en/public.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,9 @@
"There was a problem processing the request. Please try again.": "There was a problem processing the request. Please try again.",
"There was an error generating OAuth client from OIDC client.": "There was an error generating OAuth client from OIDC client.",
"There was an error generating login state.": "There was an error generating login state.",
"There was an error setting login state cookie": "There was an error setting login state cookie",
"There was an error setting login state cookie.": "There was an error setting login state cookie.",
"There was an error logging you out. Please try again.": "There was an error logging you out. Please try again.",
"There was an error parsing your state cookie": "There was an error parsing your state cookie",
"There was an error parsing your state cookie.": "There was an error parsing your state cookie.",
"There was an error verifying your session. Please log out and try again.": "There was an error verifying your session. Please log out and try again.",
"Auth code is missing in query param.": "Auth code is missing in query param.",
"There was an error logging you in. Please log out and try again.": "There was an error logging you in. Please log out and try again.",
Expand Down