Skip to content

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 1, 2025

…rride can be removed

After

localhost_9000_k8s_ns_openshift-monitoring_pods_alertmanager-main-0

@openshift-ci openshift-ci bot requested review from Leo6Leo and sg00dwin October 1, 2025 15:25
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 1, 2025
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Oct 1, 2025

/assign @logonoff

@logonoff
Copy link
Member

logonoff commented Oct 1, 2025

/assign @logonoff

I remember there being some minor visual regressions in the create forms, can you check if those still exist? If there are any regressions with console or dynamic plugins I think we should defer upgrading PF to 4.22 so we can count it as a part of our "breaking" changes

Also PF 6.4.0 is coming out soon so if we're updating to PF we should probably wait for that

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@rhamilto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn cb49fa9 link false /test okd-scos-e2e-aws-ovn
ci/prow/images cb49fa9 link true /test images
ci/prow/e2e-gcp-console cb49fa9 link true /test e2e-gcp-console
ci/prow/okd-scos-images cb49fa9 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

rhamilto commented Oct 1, 2025

/hold for PF6.4

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants