-
Notifications
You must be signed in to change notification settings - Fork 659
OCPBUGS-60969: Expose getConsoleRequestHeaders function via Console plugin API #15556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@vojtechszocs: This pull request references Jira Issue OCPBUGS-60969, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
26eda68
to
11199fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor comment on the function description, otherwise lgtm. Tested locally, the header is being created correctly with the right store instance. Thanks for the fix! @vojtechszocs
frontend/packages/console-dynamic-plugin-sdk/src/api/dynamic-core-api.ts
Outdated
Show resolved
Hide resolved
11199fc
to
9e04658
Compare
/lgtm |
/label tide/merge-method-squash QE approval + verify: |
/hold Seeing some webpack build warnings, looking into it. |
/hold cancel I've confirmed the webpack build warnings are also present without this PR, we can fix these later on. |
9e04658
to
6842678
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
@vojtechszocs: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Created in collaboration with @Leo6Leo
This fixes a bug where a dynamic plugin would use its own copy of
getConsoleRequestHeaders
function, in which case the code always returnsundefined
. Instead, calling this function should always return an object with relevant HTTP headers.To verify the changes, modify
dynamic-demo-plugin/src/components/UtilityConsumer.tsx
file as follows:ConsoleFetchConsumer
component:# consoleHeaders
have been logged as expected