Skip to content

OCPBUGS-61767: Duplicate CRs are shown as Operand instances in operator uninstallation modal #15557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-61767: Duplicate CRs are shown as Operand instances in operator uninstallation modal #15557

wants to merge 1 commit into from
+15 −0

Conversation

krishagarwal278
Copy link
Member

@krishagarwal278 krishagarwal278 commented Oct 1, 2025 •
edited
Loading

Duplicate Operand Instances in operator uninstallation modal

duplicate_operands.mp4

Fix made to remove duplicate operands

duplicate_operands.mp4

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@krishagarwal278 krishagarwal278 changed the title [WIP] OCPBUGS-61767Updated logic for sorting Operands with multiple versions [WIP] OCPBUGS-61767: Duplicate CRs are shown as Operand instances in operator uninstallation modal Oct 1, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 1, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-61767, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and Leo6Leo October 1, 2025 20:30
@openshift-ci openshift-ci bot added the component/backend Related to backend label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krishagarwal278
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-61767, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-61767, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei October 2, 2025 14:37
@krishagarwal278 krishagarwal278 changed the title [WIP] OCPBUGS-61767: Duplicate CRs are shown as Operand instances in operator uninstallation modal OCPBUGS-61767: Duplicate CRs are shown as Operand instances in operator uninstallation modal Oct 6, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-61767, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix made to remove duplicate operands

duplicate_operands.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo
Leo6Leo reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first Go Lang PR @krishagarwal278 . I have successfully tried to reproduce this issue locally, and I observed that the duplicate exist.
Screenshot 2025-10-06 at 3 52 30 PM

Testing out your changes and it does solve the duplicate issue. I left a minor suggestion to the PR, otherwise lgtm. Ping me for lgtm labels after you've reviewed the comments.

pkg/olm/handler.go
return
}

if operandsList != nil && len(operandsList.Items) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add head comment to explain how this work would help.

For example:
// Deduplicate operands by UID to prevent duplicate CRs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks so much @Leo6Leo 🚀

@krishagarwal278
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn f1d97e4 link false /test okd-scos-e2e-aws-ovn
ci/prow/frontend f1d97e4 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@yapei yapei Awaiting requested review from yapei

1 more reviewer

@Leo6Leo Leo6Leo Leo6Leo left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
component/backend Related to backend jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishagarwal278 @openshift-ci-robot @Leo6Leo