Skip to content

OCPBUGS-58468: Reload console config at runtime #15558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

OCPBUGS-58468: Reload console config at runtime #15558

wants to merge 3 commits into from

Conversation

TheRealJon
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 1, 2025
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-58468, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/backend Related to backend approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2025
TheRealJon and others added 3 commits October 3, 2025 15:25
@TheRealJon
wip
a79ab92
@TheRealJon @claude
Add config file watching and runtime server reconfiguration
842ec57 
- Created pkg/serverconfig/configwatcher.go to watch config file changes using fsnotify
- Refactored main() to run server in a loop, restarting when config changes
- Updated runServer() to handle config watcher setup and determine if restart is needed
- Moved redirect server initialization into runServer() for proper lifecycle management
- Simplified createServer() to remove fs parameter (no longer needed)

The server now gracefully restarts when the config file is modified, allowing
runtime reconfiguration without manual process restarts.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@TheRealJon
WIP: Add session persistence across config reloads
c9c3784 
- Cache session state (authenticator, CSRF verifier) across server restarts
- Only recreate sessions when session-related config changes
- Update run-bridge.sh to use static config file for testing
- Add examples/bridge-config.yaml with static development settings

Users now stay logged in when non-session config changes (branding, plugins, etc.)
Sessions are only invalidated when auth config actually changes.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealJon @openshift-ci-robot