[WIP] TESTING PatternFly 6.4.0 prerelease packages #15563
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sg00dwin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/core
| setSelected(selections as string[]); | ||
| onChange(selections as string[]); |
There was a problem hiding this comment.
could we avoid type assertion here?
| placeholder={placeholder || t('console-shared~Select options')} | ||
| noOptionsFoundMessage={t('console-shared~No results found')} | ||
| // @ts-expect-error FIXME: PatternFly's onSelect is typed wrong (value should be any) | ||
| onSelectionChange={onSelect} |
There was a problem hiding this comment.
onSelectionChange is currently: selections: (string | number)[]
is there a resolution for this or will we have to change it to 'any' later?
| toggle={toggle} | ||
| isOpen={isOpen} | ||
| // @ts-expect-error FIXME: PatternFly's onSelect is typed wrong (value should be any) | ||
| onSelect={(_, selectedValue: TelemetryAnalyticsSelectOptions) => { |
| isOpen={isOpen} | ||
| toggleId="telemetry" | ||
| // @ts-expect-error FIXME: PatternFly's onSelect is typed wrong (value should be any) | ||
| onSelect={(_, selectedValue?: TelemetryAnalyticsSelectOptions) => { |
sg00dwin
force-pushed
the
PF-6.4.0-prerelease.2-OCT2
branch
from
ea30b48 to
648f27d
Compare
|
/retest |
|
@sg00dwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.