Skip to content

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Oct 7, 2025

Description

Add multi-group support to Redux actions:

  • Update startImpersonate to accept groups parameter
  • Encode multiple groups as WebSocket subprotocols in UserWithGroups mode
  • Pass groups to beginImpersonate action
  • Expose store and UIActions for testing (temporary)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2025

@Leo6Leo: This pull request references CONSOLE-4787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Description

Add multi-group support to Redux actions:

  • Update startImpersonate to accept groups parameter
  • Encode multiple groups as WebSocket subprotocols in UserWithGroups mode
  • Pass groups to beginImpersonate action
  • Expose store and UIActions for testing (temporary)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 7, 2025
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign cajieh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Oct 7, 2025
Comment on lines +62 to +68
// Temporary: Expose store for testing multi-group impersonation
// TODO: Remove this after testing. This SHOULD NOT BE IN MERGED in production!!!!!
(window as any).store = store;

// Expose UI actions for testing
import * as UIActions from './actions/ui';
(window as any).UIActions = UIActions;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danger: this part of the code just used here for showcasing how you can test this action out. It should be removed before getting merged.

Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@Leo6Leo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 7d50aaf link true /test frontend
ci/prow/analyze 7d50aaf link true /test analyze
ci/prow/images 7d50aaf link true /test images
ci/prow/e2e-gcp-console 7d50aaf link true /test e2e-gcp-console
ci/prow/okd-scos-images 7d50aaf link true /test okd-scos-images
ci/prow/okd-scos-e2e-aws-ovn 7d50aaf link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/sdk Related to console-plugin-sdk jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants