-
Notifications
You must be signed in to change notification settings - Fork 659
CONSOLE-4787: Redux Actions & States Updates for multi-group impersonation #15574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CONSOLE-4787: Redux Actions & States Updates for multi-group impersonation #15574
Conversation
@Leo6Leo: This pull request references CONSOLE-4787 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Leo6Leo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// Temporary: Expose store for testing multi-group impersonation | ||
// TODO: Remove this after testing. This SHOULD NOT BE IN MERGED in production!!!!! | ||
(window as any).store = store; | ||
|
||
// Expose UI actions for testing | ||
import * as UIActions from './actions/ui'; | ||
(window as any).UIActions = UIActions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danger: this part of the code just used here for showcasing how you can test this action out. It should be removed before getting merged.
@Leo6Leo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Add multi-group support to Redux actions: