Skip to content

Conversation

PeterYurkovich
Copy link
Contributor

This PR looks to update the /dev-monitoring/ns/{NS}/X links to the new /monitoring/X?namespace={NS} format.

It also removes a number of dev-perspective specific tests for the observe section which are no longer needed as the pages have been moved to the admin perspective under the observe section and who's tests will now reside within the monitoring-plugin repo.

This PR works in conjugation with openshift/monitoring-plugin#567 and should be merged first if possible to prevent any potential CI issues.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2025

@PeterYurkovich: This pull request references OU-949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR looks to update the /dev-monitoring/ns/{NS}/X links to the new /monitoring/X?namespace={NS} format.

It also removes a number of dev-perspective specific tests for the observe section which are no longer needed as the pages have been moved to the admin perspective under the observe section and who's tests will now reside within the monitoring-plugin repo.

This PR works in conjugation with openshift/monitoring-plugin#567 and should be merged first if possible to prevent any potential CI issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 7, 2025
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PeterYurkovich
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared labels Oct 7, 2025
@PeterYurkovich
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants