-
Notifications
You must be signed in to change notification settings - Fork 659
Bug 1745431: Birthday attack against 64-bit block ciphers [Release-3.11.z] #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@benjaminapetersen: This pull request references Bugzilla bug 1745431, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@benjaminapetersen: This pull request references Bugzilla bug 1745431, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
test-ciphers.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atm not calling this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spadgett think we need to get the test running? Since we are missing the test-prow-e2e.sh
file at 3.11, test-ciphers.sh
is not running.
@benjaminapetersen: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest
|
/retest Cloning issues again:
|
I'm not sure why ci/prow/analyze are running... Neither of those tests should run against the relase-3.11 branch. |
/hold /override ci/prow/analyze |
@spadgett: Overrode contexts on behalf of spadgett: ci/prow/analyze, ci/prow/e2e-gcp-console In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- add bash script to test a sample of good ciphers & bad ciphers - fixes CVE SSL/TLS: Birthday attack against 64-bit block ciphers (SWEET32)
fc732c4
to
1200e53
Compare
New changes are detected. LGTM label has been removed. |
|
@spadgett since we resolved the |
@spadgett just for a fresh |
Scratch that, we can keep the hold, this is incomplete. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@benjaminapetersen: This pull request references Bugzilla bug 1745431. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual backport of #3389
One problem, the
test-prow-e2e.sh
file does not exist at this point. Contemplating how to wire up the test properly.