Skip to content

Conversation

benjaminapetersen
Copy link
Contributor

Manual backport of #3389

One problem, the test-prow-e2e.sh file does not exist at this point. Contemplating how to wire up the test properly.

@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1745431, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "3.11.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1745431: Birthday attack against 64-bit block ciphers [OpenShift 3.11.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 5, 2019
@benjaminapetersen benjaminapetersen changed the base branch from master to release-3.11 December 5, 2019 22:16
@openshift-ci-robot openshift-ci-robot added component/backend Related to backend bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1745431, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1745431: Birthday attack against 64-bit block ciphers [OpenShift 3.11.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2019
test-ciphers.sh Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atm not calling this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett think we need to get the test running? Since we are missing the test-prow-e2e.sh file at 3.11, test-ciphers.sh is not running.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2019

@benjaminapetersen: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/analyze fc732c4c4ed1b5c4fc3f539a4f69d2852442f0f8 link /test analyze
ci/prow/e2e-gcp-console fc732c4c4ed1b5c4fc3f539a4f69d2852442f0f8 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett added this to the v3.11.z milestone Dec 6, 2019
@benjaminapetersen
Copy link
Contributor Author

/retest

could not wait for build: the build src failed with reason DockerBuildFailed: Docker build strategy has failed.  e-class.tsx\nCONFLICT (modify/delete): frontend/public/com...d then commit the result.\n","time":"2019-12-05T22:16:58Z"} {"component":"clonerefs","error":"one or more of the recor..."msg":"Failed to clone refs","time":"2019-12-05T22:16:58Z"} error: build error: running 'umask 0002 && /clonerefs && f... -perm -0775 \| xargs -r chmod g+xw' failed with exit code 1

@benjaminapetersen
Copy link
Contributor Author

/retest

Cloning issues again:

could not wait for build: the build src failed with reason DockerBuildFailed: Docker build strategy has failed.

e-class.tsx\nCONFLICT (modify/delete): frontend/public/com...d then commit the result.\n","time":"2019-12-05T22:16:58Z"}
{"component":"clonerefs","error":"one or more of the recor..."msg":"Failed to clone refs","time":"2019-12-05T22:16:58Z"}
error: build error: running 'umask 0002 && /clonerefs && f... -perm -0775 | xargs -r chmod g+xw' failed with exit code 1

@spadgett
Copy link
Member

spadgett commented Dec 7, 2019

I'm not sure why

ci/prow/analyze
ci/prow/e2e-gcp-console

are running... Neither of those tests should run against the relase-3.11 branch.

@spadgett
Copy link
Member

spadgett commented Dec 7, 2019

/hold
Until this is validated in 4.x.

/override ci/prow/analyze
/override ci/prow/e2e-gcp-console
These tests should not run against release-3.11.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/analyze, ci/prow/e2e-gcp-console

In response to this:

/hold
Until this is validated in 4.x.

/override ci/prow/analyze
/override ci/prow/e2e-gcp-console
These tests should not run against release-3.11.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- add bash script to test a sample of good ciphers & bad ciphers
- fixes CVE SSL/TLS: Birthday attack against 64-bit block ciphers (SWEET32)
@benjaminapetersen benjaminapetersen force-pushed the backport/release-3.11/bug/1745431/birthday-attack-against-64-bit-block-ciphers branch from fc732c4 to 1200e53 Compare December 9, 2019 15:48
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2019
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@benjaminapetersen
Copy link
Contributor Author

chmod +x ./test-ciphers.sh here as well, tho it isn't running. No reason to leave the perms incorrect.

@benjaminapetersen
Copy link
Contributor Author

@spadgett since we resolved the ./test-ciphers.sh dilemma, just need a new lgtm and this can go once the 4.1 lands.

@benjaminapetersen
Copy link
Contributor Author

@spadgett just for a fresh lgtm.

@benjaminapetersen benjaminapetersen changed the title Bug 1745431: Birthday attack against 64-bit block ciphers [OpenShift 3.11.z] Bug 1745431: Birthday attack against 64-bit block ciphers [Release-3.11.z] Dec 16, 2019
@benjaminapetersen
Copy link
Contributor Author

Scratch that, we can keep the hold, this is incomplete.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2020
@spadgett spadgett closed this Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1745431. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1745431: Birthday attack against 64-bit block ciphers [Release-3.11.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants