[release-4.7] Bug 1947091: Fix skipped task status when using conditions #8582

karthikjeeyar · 2021-04-07T16:22:06Z

This is a manual cherrypick of #8577

Fixes:

https://issues.redhat.com/browse/ODC-5743

Analysis / Root cause:

If When expression or conditions are used in a pipeline, then all the skipped tasks status are shown incorrectly.

Solution Description:

Pass the isSkipped prop to the task component to show the skipped status.

Screen shots / Gifs for design review:

PipelineRun details page visualization

List page component

Test setup:

Create the pipelineRun using https://github.com/tektoncd/pipeline/blob/main/examples/v1beta1/pipelineruns/using-optional-workspaces-in-when-expressions.yaml

Browser conformance:

Chrome
Firefox
Safari
Edge

/kind bug

openshift-ci-robot · 2021-04-07T16:22:07Z

@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix skipped task status when using conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-07T16:24:19Z

@karthikjeeyar: This pull request references Bugzilla bug 1947091, which is invalid:

expected dependent Bugzilla bug 1947078 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1947091: Fix skipped task status when using conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2021-04-07T17:23:41Z

@karthikjeeyar There are no finally tasks in 4.7... where did you get that screenshot?

openshift-ci-robot · 2021-04-07T19:06:53Z

@karthikjeeyar: This pull request references Bugzilla bug 1947091, which is invalid:

expected dependent Bugzilla bug 1947078 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1947091: Fix skipped task status when using conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar · 2021-04-07T19:07:41Z

@andrewballantyne Updated the screenshots with 4.7 images. Previously I grabbed it from my other PR.

rottencandy

/lgtm

openshift-ci-robot · 2021-04-08T08:59:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/pipelines-plugin/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-08T09:01:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-08T09:27:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-08T11:24:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-09T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-09T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1947091, which is invalid:

expected dependent Bugzilla bug 1947078 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-10T01:00:26Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-10T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1947091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1947078 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1947078 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2021-04-12T16:04:57Z

/hold

Waiting for #8619 to merge for the kubevirt-plugin tests to be fixed.

mfojtik · 2021-04-14T14:30:55Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

Score: 0.20
Reason: maximum total for this z-stream is 10

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

andrewballantyne · 2021-04-16T17:08:12Z

/unhold
/retest

sdodson · 2021-05-27T18:58:04Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

We've hit capacity of 50 for this week.

Score: 0.20
Reason: maximum QE capacity for all z-stream is 50

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

derekwaynecarr · 2021-06-03T21:47:49Z

[patch-manager] 🚀 Approved for z-stream by score: 0.20

approved

openshift-bot · 2021-06-04T04:06:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-04T07:07:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-04T07:43:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

andrewballantyne · 2021-06-04T16:38:57Z

/retest

openshift-bot · 2021-06-06T09:35:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-07T00:18:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-06-07T03:28:48Z

@karthikjeeyar: All pull requests linked via external trackers have merged:

openshift/console#8582

Bugzilla bug 1947091 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1947091: Fix skipped task status when using conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix skipped task status when using conditions

872f979

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 7, 2021

openshift-ci-robot requested review from jeff-phillips-18 and vikram-raj April 7, 2021 16:22

karthikjeeyar changed the title ~~Fix skipped task status when using conditions~~ [release-4.7] Bug 1947091: Fix skipped task status when using conditions Apr 7, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 7, 2021

andrewballantyne approved these changes Apr 7, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021

rottencandy approved these changes Apr 8, 2021

View reviewed changes

openshift-ci-robot assigned rottencandy Apr 8, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 10, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 10, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021

derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2021

openshift-merge-robot merged commit dcf1720 into openshift:release-4.7 Jun 7, 2021

spadgett added this to the v4.7.z milestone Jun 8, 2021

[release-4.7] Bug 1947091: Fix skipped task status when using conditions #8582

[release-4.7] Bug 1947091: Fix skipped task status when using conditions #8582

Uh oh!

Conversation

karthikjeeyar commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

andrewballantyne commented Apr 7, 2021

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

karthikjeeyar commented Apr 7, 2021

Uh oh!

rottencandy left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 8, 2021

Uh oh!

openshift-bot commented Apr 9, 2021

Uh oh!

openshift-ci-robot commented Apr 9, 2021

Uh oh!

openshift-bot commented Apr 10, 2021

Uh oh!

openshift-ci-robot commented Apr 10, 2021

Uh oh!

andrewballantyne commented Apr 12, 2021

Uh oh!

mfojtik commented Apr 14, 2021

Uh oh!

andrewballantyne commented Apr 16, 2021

Uh oh!

sdodson commented May 27, 2021

Uh oh!

derekwaynecarr commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 4, 2021

Uh oh!

openshift-bot commented Jun 4, 2021

Uh oh!

openshift-bot commented Jun 4, 2021

Uh oh!

andrewballantyne commented Jun 4, 2021

Uh oh!

openshift-bot commented Jun 6, 2021

Uh oh!

openshift-bot commented Jun 7, 2021

Uh oh!

openshift-ci bot commented Jun 7, 2021

Uh oh!

Uh oh!

karthikjeeyar commented Apr 7, 2021 •

edited

Loading