ODC-6140-Removed dotnet related gherkin script from this pipelines plugin folder #9493
Conversation
openshift-ci
bot
added
component/pipelines
|
I see similar builder image detection integration tests in dev-console package, we could add the context directory test there in all applicable Add flows (import from git, import from dockerfile etc). Maybe add a separate ticket for adding the context directory tests in dev-console package? so this PR can go in, WDYT? |
Added new test scenarios for other builder images within this pr |
|
Please note, As per my understanding from different sources. For servers "httpd", "nginx" builder images are not detected. So that's the reason. pipeline templates are not available. Please let me know if something is wrong |
There was a problem hiding this comment.
Could we add a step here that the user will be able to see Unable to detect the Builder Image.?
There was a problem hiding this comment.
It makes sense to add the above scenario for httpd/nginx, as we will not able to detect it. Definitely gives clarity to the whoever tests it manually.
There was a problem hiding this comment.
Its a verification step, so i added it in Then statement (Line no. 197) instead of adding it in "When" statement
There was a problem hiding this comment.
| Scenario Outline: Dotnet Builder iamge detection for git url "<git_url>": A-06-TC13 | |
| Scenario Outline: Dotnet Builder image detection for git url "<git_url>": A-06-TC13 |
There was a problem hiding this comment.
nit:
| And user selects Show advanced Git options | |
| And user clicks on "Show advanced Git options" link |
There was a problem hiding this comment.
by default / will be already present in context dir field, should we drop preceding / from the example?
| | https://github.com/redhat-developer/s2i-dotnetcore-ex.git | /app | dotnetcore-ex-git-app | dotnetcore-ex-git | | |
| | https://github.com/redhat-developer/s2i-dotnetcore-ex.git | app | dotnetcore-ex-git-app | dotnetcore-ex-git | |
There was a problem hiding this comment.
I will add one more step for clearing the field to give more clarity, instead of modifying the data
There was a problem hiding this comment.
| Scenario Outline: Select Builder iamge manually for server related git urls": A-06-TC14 | |
| Scenario Outline: Select Builder image manually for server related git urls": A-06-TC14 |
There was a problem hiding this comment.
fix typo and order of the events.
| And user selects "<builder_image>" builder image | |
| Then git url gets Validated | |
| And warning message displays as "Unabel to detect the Builder Image" in Builder section | |
| And git url gets Validated | |
| And warning message displays as "unable to detect the Builder Image" in Builder section | |
| Then user selects "<builder_image>" builder image |
There was a problem hiding this comment.
Action statement should be performed on When statement
verification should be performed on Then statement
There was a problem hiding this comment.
For more clarity, removing the "Selecting the builder image" when statement
There was a problem hiding this comment.
Removing this line
| And user enters Context dir as "<dir_name>" | ||
| Then git url gets Validated | ||
| And user is able to see "Builder Image(s) detected" message in Builder section | ||
| And .NET builder image card tile is highlighted with * mark |
There was a problem hiding this comment.
Since you are using Examples, lets not bound .NET to the gherkin script, how about using <runtime>?
| And .NET builder image card tile is highlighted with * mark | |
| And <runtime> builder image card tile is highlighted with * mark |
There was a problem hiding this comment.
There is only one example right?, why do we need parameter for this step
There was a problem hiding this comment.
Usually the scenario Outline Keyword will be used to run the same (generic) scenario multiple times with various values and to avoid repetitions, but here it is only one example and it is bound to dotnet, so that is where I get confused. Either it has to be a generic scenario or specific to dotnet with inline values, as you said it is only one example.
|
|
||
|
|
||
| @regression @manual | ||
| Scenario Outline: Dotnet Builder image detection for git url "<git_url>": A-06-TC13 |
There was a problem hiding this comment.
Shouldn't the scenario outline title be generic to test the context dir flow instead of this scenario bound to Dotnet?
There was a problem hiding this comment.
We have only one builder image right related to context directory, so i don't think it is to be Generic
There was a problem hiding this comment.
No, Context directory is field is where you can provide subfolder name,
for example:
In this reposistory https://github.com/sclorg/s2i-nodejs-container, there are many subfolders for each versions, so if you want to specifically use nodejs 14 then in the context dir you need to provide /14. It is a generic field and not only dotnet builder image. IMO, this scenario could be a generic but I am fine if you are okay with having dotnet specific test case.
There was a problem hiding this comment.
yeah I agree context dir field is generic, but I want to make sure this dotnet scenario is covered
|
|
||
|
|
||
| @regression @manual | ||
| Scenario Outline: Add Pipeline option display for dotnet builder image with context directory": P-01-TC09 |
There was a problem hiding this comment.
Technically, Pipeline option will be displayed if the templates are available for selected builderImage + resourceType combination, it has nothing to do with context dir, we could remove this scenario, It is not needed.
There was a problem hiding this comment.
yes, but this dotnet builder image is not covered in earlier scenario right, so I think better to be include this scenario.
To make sure no scenarios are missed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, makambalaji The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Jira Id:
As part of this bug: https://issues.redhat.com/browse/ODC-6140, the changes made for this pr
Acceptance Criteria:
Removed the dotnet example present in scenario P-01-TC08 "create-from-add-options.feature" file
Added the scenarios for the dotnet and other server git urls
Pre-conditions for Epic validation:
NA
Refactoring Gherkin scripts criteria for approving PR:
yarn run gherkin-linton frontend folder [Skip epic number tags related linter issues]