Skip to content

[release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user #9516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

[release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user #9516

merged 1 commit into from
Aug 13, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9428

/assign spadgett

@guillaumerose
Remove kube admin notifier for kubeadmin crc user
88fcca7 
The OAuth configuration is already changed by crc. The password for the
kubeadmin user is rotated automatically.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 14, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: Bugzilla bug 1980257 has been cloned as Bugzilla bug 1982458. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user

In response to this:

[release-4.8] Bug 1980257: Remove kube admin notifier for kubeadmin crc user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcaianirh and zherman0 July 14, 2021 22:23
@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Jul 14, 2021
@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1980257: Remove kube admin notifier for kubeadmin crc user [release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user Jul 14, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1982458, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1980257 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1980257 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

[release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 14, 2021 22:23
@XiyunZhao
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 5, 2021
spadgett
spadgett approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett, XiyunZhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 13, 2021
@openshift-ci openshift-ci bot merged commit 99b4ace into openshift:release-4.8 Aug 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1982458 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1982458: Remove kube admin notifier for kubeadmin crc user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8.z milestone Aug 30, 2021
@cfergeau cfergeau mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@zherman0 zherman0 Awaiting requested review from zherman0

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

@XiyunZhao XiyunZhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.8.z
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @XiyunZhao @openshift-bot @spadgett @bparees @guillaumerose