[release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret #9651

openshift-cherrypick-robot · 2021-07-27T20:04:53Z

This is an automated cherry-pick of #9472

/assign kdoberst

Remove logic from modal for displaying existing pull secret Fixed a bug that was allowing users to upload bad JSON without warning. Prevent saving secret if uploading config.json is empty

openshift-ci · 2021-07-27T20:05:01Z

@openshift-cherrypick-robot: Bugzilla bug 1980704 has been cloned as Bugzilla bug 1986581. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret

In response to this:

[release-4.8] Bug 1980704: Web console doesn't list all the registries credentials in a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-27T20:06:09Z

@openshift-cherrypick-robot: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1986581 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n  \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

/lgtm

openshift-bot · 2021-07-28T07:43:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T08:09:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T08:22:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T08:35:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T09:40:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T10:58:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T13:34:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-28T14:47:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

spadgett

/lgtm

kdoberst · 2021-07-28T18:46:20Z

/bugzilla refresh

openshift-ci · 2021-07-28T18:46:25Z

@kdoberst: This pull request references Bugzilla bug 1986581, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1980704 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1980704 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2021-08-04T19:03:19Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

Score: 0.20
Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

yanpzhan · 2021-08-05T07:21:35Z

/bugzilla refresh

openshift-ci · 2021-08-05T07:21:39Z

@yanpzhan: This pull request references Bugzilla bug 1986581, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1980704 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1980704 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanpzhan · 2021-08-05T09:58:37Z

Tested against the pr, steps to test:

Create a new project, on the project details page, click on "Not configured" link under the "Default pull secret" section
Choose the "Upload Docker config.json" option and selected my file created in the first step.
Click on save.
Then go to the project details, under the "Default pull secret" header there is a resource link that has the name of the created secret
When click on the secret link, it goes to the secret details page. There is "Save file" link on the page, click it, a file with all registry entries is downloaded.
From the result user could get all registry credentials.

yanpzhan · 2021-08-05T09:59:00Z

/label qe-approved

yanpzhan · 2021-08-05T09:59:09Z

/lgtm

openshift-ci · 2021-08-05T09:59:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett, yanpzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ecordell · 2021-08-05T18:54:46Z

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

Score: 0.20
Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

ecordell · 2021-08-05T18:55:35Z

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

ecordell · 2021-08-05T22:39:12Z

/retest

openshift-bot · 2021-08-06T08:30:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-06T09:30:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-06T10:16:36Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/console#9651

Bugzilla bug 1986581 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Link to secret if exists instead of showing modal

96fb0ee

Remove logic from modal for displaying existing pull secret Fixed a bug that was allowing users to upload bad JSON without warning. Prevent saving secret if uploading config.json is empty

openshift-ci bot assigned kdoberst Jul 27, 2021

openshift-cherrypick-robot mentioned this pull request Jul 27, 2021

Bug 1980704: Web console doesn't list all the registries credentials in a secret #9472

Merged

openshift-ci bot changed the title ~~[release-4.8] Bug 1980704: Web console doesn't list all the registries credentials in a secret~~ [release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret Jul 27, 2021

openshift-ci bot requested review from jeff-phillips-18 and kyoto July 27, 2021 20:06

openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 27, 2021

spadgett approved these changes Jul 27, 2021

View reviewed changes

openshift-ci bot assigned spadgett Jul 27, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2021

spadgett approved these changes Jul 28, 2021

View reviewed changes

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 28, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 28, 2021

openshift-ci bot requested a review from yapei July 28, 2021 18:46

openshift-ci bot requested a review from yanpzhan August 5, 2021 07:21

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 5, 2021

openshift-ci bot assigned yanpzhan Aug 5, 2021

ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021

openshift-ci bot merged commit 36be9ef into openshift:release-4.8 Aug 6, 2021

spadgett added this to the v4.8.z milestone Aug 30, 2021

[release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret #9651

[release-4.8] Bug 1986581: Web console doesn't list all the registries credentials in a secret #9651

Uh oh!

Conversation

openshift-cherrypick-robot commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

openshift-bot commented Jul 28, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

kdoberst commented Jul 28, 2021

Uh oh!

openshift-ci bot commented Jul 28, 2021

Uh oh!

ecordell commented Aug 4, 2021

Uh oh!

yanpzhan commented Aug 5, 2021

Uh oh!

openshift-ci bot commented Aug 5, 2021

Uh oh!

yanpzhan commented Aug 5, 2021

Uh oh!

yanpzhan commented Aug 5, 2021

Uh oh!

yanpzhan commented Aug 5, 2021

Uh oh!

openshift-ci bot commented Aug 5, 2021

Uh oh!

ecordell commented Aug 5, 2021

Uh oh!

ecordell commented Aug 5, 2021

Uh oh!

ecordell commented Aug 5, 2021

Uh oh!

openshift-bot commented Aug 6, 2021

Uh oh!

openshift-bot commented Aug 6, 2021

Uh oh!

openshift-ci bot commented Aug 6, 2021

Uh oh!

Uh oh!