-
Notifications
You must be signed in to change notification settings - Fork 659
Bug 1985356: Check for nonexistent CSVs in installed block #9735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1985356: Check for nonexistent CSVs in installed block #9735
Conversation
The installed hint block for operators wasn't checking to see if the operator had a CSV or not in the K8sWatch hook. As a result, sometimes it would show an incorrect CSV link if there was no CSV on the operator. I added some additional logic to check so we can route them to the subscription if this happens. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1985356
@rebeccaalpert: This pull request references Bugzilla bug 1985356, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[patch-manager] 🚀 Approved for z-stream by score: 0.20 picked |
@rebeccaalpert: All pull requests linked via external trackers have merged: Bugzilla bug 1985356 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/label qe-approved |
This issue has been checked on OCP 4.8 and 4.9, when creating a subscription with a non-existing starting CSV specified, the Installed Operators reports Unknown state on the details page |
The installed hint block for operators wasn't checking to see if the operator had a CSV or not in the K8sWatch hook. As a result, sometimes it would show an incorrect CSV link if there was no CSV on the operator. I added some additional logic to check so we can route them to the subscription if this happens.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1985356.