Skip to content

Conversation

rebeccaalpert
Copy link
Contributor

The installed hint block for operators wasn't checking to see if the operator had a CSV or not in the K8sWatch hook. As a result, sometimes it would show an incorrect CSV link if there was no CSV on the operator. I added some additional logic to check so we can route them to the subscription if this happens.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1985356.

The installed hint block for operators wasn't checking to see if the operator had a CSV or not in the K8sWatch hook. As a result, sometimes it would show an incorrect CSV link if there was no CSV on the operator. I added some additional logic to check so we can route them to the subscription if this happens.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1985356
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@rebeccaalpert: This pull request references Bugzilla bug 1985356, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1970466 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1970466 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1985356: Check for nonexistent CSVs in installed block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from yapei, spadgett and TheRealJon August 5, 2021 02:11
@openshift-ci openshift-ci bot added the component/olm Related to OLM label Aug 5, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021
@openshift-ci openshift-ci bot merged commit 9ecd9ec into openshift:release-4.8 Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@rebeccaalpert: All pull requests linked via external trackers have merged:

Bugzilla bug 1985356 has been moved to the MODIFIED state.

In response to this:

Bug 1985356: Check for nonexistent CSVs in installed block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XiyunZhao
Copy link

/lgtm

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 6, 2021
@XiyunZhao
Copy link

XiyunZhao commented Aug 6, 2021

This issue has been checked on OCP 4.8 and 4.9, when creating a subscription with a non-existing starting CSV specified, the Installed Operators reports Unknown state on the details page

@spadgett spadgett added this to the v4.8.z milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants