Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure. #9974

sg00dwin · 2021-09-02T11:15:56Z

Removes the need for dynamic plugin css page level overrides.
Sidebar nav pf-c-page__sidebar breakpoint now uses the PF default 1200px which is tied into the default pf-c-page grid template area @media breakpoint.
A couple z-index changes so that notification drawer, fullscreen terminal, and Help menu position correctly

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1995545 (Project drop-down hidden behind PF wizard)

Related
Dynamic Plugin demo page #9679
PF page component https://www.patternfly.org/v4/components/page
PF page with drawer demo that most closely matches our console markup. https://www.patternfly.org/v4/components/drawer/html-demos#expanded because of how we pull in the ConnectedNotificationDrawer

spadgett · 2021-09-02T12:57:18Z

@jamestalton FYI

rhamilto

One nit.

What's your confidence on this, @sg00dwin?

frontend/public/components/_global-notification.scss

sg00dwin · 2021-09-02T21:58:11Z

One nit.

What's your confidence on this, @sg00dwin?

Removed after our conversation

rexagod · 2021-09-06T06:06:38Z

/bugzilla refresh

openshift-ci · 2021-09-06T06:06:39Z

@rexagod: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-07T13:41:23Z

@sg00dwin: This pull request references Bugzilla bug 1995545, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sg00dwin · 2021-09-07T13:42:24Z

/bugzilla refresh

openshift-ci · 2021-09-07T13:42:31Z

@sg00dwin: This pull request references Bugzilla bug 1995545, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sg00dwin · 2021-09-15T18:14:01Z

/retest

dtaylor113 · 2021-09-17T13:29:19Z

/retest

sg00dwin · 2021-09-17T15:07:34Z

/test ceph-storage-plugin

rhamilto

The scrollbar now overlaps with areas that are not scrollable. I assume this is expected given the sticky positioning of the global notifications and project picker, but wanted to point it out in the event it is unexpected.

frontend/public/style/_overrides.scss

frontend/public/components/app-contents.tsx

…verrides are needed and do not interfere with default PF component usage. Relates to dynamic plugin override issues

rhamilto

/lgtm

openshift-ci · 2021-09-22T19:17:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-09-22T23:03:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-23T00:08:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-23T01:06:52Z

@sg00dwin: All pull requests linked via external trackers have merged:

openshift/console#9974

Bugzilla bug 1995545 has been moved to the MODIFIED state.

In response to this:

Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…for-better-alignment-with-PF Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure.

sg00dwin assigned rhamilto Sep 2, 2021

openshift-ci bot requested review from jcaianirh and rhamilto September 2, 2021 11:16

rhamilto reviewed Sep 2, 2021

View reviewed changes

frontend/public/components/_global-notification.scss Outdated Show resolved Hide resolved

sg00dwin changed the title ~~Console 2926: Update console page markup structure to closer align with Patternfly page component structure.~~ [WIP] Console 2926: Update console page markup structure to closer align with Patternfly page component structure. Sep 2, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2021

sg00dwin force-pushed the app-page-restructure-for-better-alignment-with-PF branch from 324c20c to 39419bf Compare September 2, 2021 21:56

rexagod mentioned this pull request Sep 6, 2021

Bug 1995545: Adjust ZIndex value for the dropdown menu #9893

Closed

sg00dwin force-pushed the app-page-restructure-for-better-alignment-with-PF branch from 39419bf to ab620da Compare September 7, 2021 13:40

sg00dwin changed the title ~~[WIP] Console 2926: Update console page markup structure to closer align with Patternfly page component structure.~~ Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure. Sep 7, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 7, 2021

sg00dwin force-pushed the app-page-restructure-for-better-alignment-with-PF branch 3 times, most recently from aa4bcc4 to b6f5fb8 Compare September 14, 2021 20:54

openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Sep 14, 2021

sg00dwin force-pushed the app-page-restructure-for-better-alignment-with-PF branch 2 times, most recently from 480bfbf to 79a3a68 Compare September 16, 2021 19:56

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Sep 16, 2021

openshift-ci bot added the component/olm Related to OLM label Sep 16, 2021

rhamilto reviewed Sep 17, 2021

View reviewed changes

frontend/public/style/_overrides.scss Outdated Show resolved Hide resolved

frontend/public/style/_overrides.scss Outdated Show resolved Hide resolved

rhamilto reviewed Sep 17, 2021

View reviewed changes

frontend/public/components/app-contents.tsx Outdated Show resolved Hide resolved

frontend/public/components/app-contents.tsx Outdated Show resolved Hide resolved

Bring app pages alignment closer to PF4 page structure so that less o…

b276e3d

…verrides are needed and do not interfere with default PF component usage. Relates to dynamic plugin override issues

sg00dwin force-pushed the app-page-restructure-for-better-alignment-with-PF branch from 79a3a68 to b276e3d Compare September 22, 2021 14:46

rhamilto approved these changes Sep 22, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021

rhamilto mentioned this pull request Sep 22, 2021

refactor(variables): updated theming vars #9594

Merged

openshift-merge-robot merged commit c6923b9 into openshift:master Sep 23, 2021

sg00dwin deleted the app-page-restructure-for-better-alignment-with-PF branch September 23, 2021 14:43

spadgett added this to the v4.10 milestone Sep 23, 2021

karthikjeeyar mentioned this pull request Jan 17, 2022

Bug 2038115: Make namespace bar full width and sticky in console #10856

Merged

4 tasks

Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure. #9974

Console 2926: Bug 1995545: Update console page markup structure to closer align with Patternfly page component structure. #9974

Uh oh!

Conversation

sg00dwin commented Sep 2, 2021

Uh oh!

spadgett commented Sep 2, 2021

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sg00dwin commented Sep 2, 2021

Uh oh!

rexagod commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 7, 2021

Uh oh!

sg00dwin commented Sep 7, 2021

Uh oh!

openshift-ci bot commented Sep 7, 2021

Uh oh!

sg00dwin commented Sep 15, 2021

Uh oh!

dtaylor113 commented Sep 17, 2021

Uh oh!

sg00dwin commented Sep 17, 2021

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rhamilto left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 22, 2021

Uh oh!

openshift-bot commented Sep 22, 2021

Uh oh!

openshift-bot commented Sep 23, 2021

Uh oh!

openshift-ci bot commented Sep 23, 2021

Uh oh!

Uh oh!