Bug 1997245: Dont validate the install operator form when submitted

[jhadvig]

This is an race issue, cause the form is still being evaluated while its being submitted, and the necessary resources are being created, in this case Subscription object.

Adding inProgress state that should prevent form validation.

/assign @TheRealJon

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1997245, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1997245: Dont validate the install operator form when submitted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/bugzilla refresh

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1997245, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

Maybe I'm wrong, but couldn't this render the string true while the form is being submitted.

I think it's easier to understand with an early return anyway.

if (inProgress) {
  return null;
}

// ...

[spadgett]

You should be able to remove this line now.

[jhadvig]

@spadgett comment addressed

[openshift-merge-robot]

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

[openshift-ci]

@openshift-merge-robot: This pull request references Bugzilla bug 1997245, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/bugzilla refresh

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1997245, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/operator-lifecycle-manager/OWNERS [jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@jhadvig: All pull requests linked via external trackers have merged:

• openshift/console#9976

Bugzilla bug 1997245 has been moved to the MODIFIED state.

In response to this:

Bug 1997245: Dont validate the install operator form when submitted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jhadvig: new pull request created: #10041

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[redhatHameed]

@jhadvig We are facing a similar issue with the DBaaS Operator. When we try to install it from OperatorHub, we receive an error message that says A subscription for the operator already exists, as seen in the screenshot below. However, the operator is still installed successfully. The DBaaS Operator, like ODF, has a UI component that is added as a plugin to the console. This may be the root cause of the issue