Skip to content

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Sep 6, 2021

No description provided.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2021

@gouyang: This pull request references Bugzilla bug 2001578, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001578: add tests for vm dashboard tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 2001578, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2001578: add tests for vm dashboard tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Sep 6, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Sep 7, 2021

/retest

@gouyang gouyang force-pushed the vm_dashboard branch 5 times, most recently from 041eaa0 to 6aa296b Compare September 8, 2021 08:04
@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

4 similar comments
@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Sep 8, 2021

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Sep 9, 2021

@yaacov @pcbailey PTAL, thanks!

@yaacov
Copy link
Member

yaacov commented Sep 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7d60eb9 into openshift:master Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 2001578 has been moved to the MODIFIED state.

In response to this:

Bug 2001578: add tests for vm dashboard tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants