STOR-2600, OCPBUGS-61436, OCPBUGS-61450: Bump OLM metadata to 4.21 #430
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rhrmo: This pull request references STOR-2600 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhrmo: GitHub didn't allow me to request PR reviews from the following users: openshift/storage-qe, openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, rhrmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold I need to add |
openshift-ci
bot
added
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Makefile
Outdated
| ) | ||
|
|
||
| # Bump OCP version in CSV and OLM metadata | ||
| # Also updates the Makefile and README.md to the new version |
There was a problem hiding this comment.
The script doesn't do this (in this PR) but it does in openshift/gcp-filestore-csi-driver-operator#126 -- do you want to copy that logic here?
There was a problem hiding this comment.
Actually copying the logic wouldn't make sense in this repo, but can you update the comment?
There was a problem hiding this comment.
Oh right, I will update the comment, thank you for noticing it slipped by me.
rhrmo
changed the title
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@rhrmo: This pull request references STOR-2600 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-61436, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-61450, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhrmo: This pull request references STOR-2600 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-61436, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. This pull request references Jira Issue OCPBUGS-61450, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rhrmo
force-pushed
the
update-metadata-4.21
branch
from
2c8af72 to
139038b
Compare
|
/lgtm |
|
/lgtm |
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
| # OCP_VERSION is an optional argument. If no argument is provided, it defaults | ||
| # to the version found in .channels[0].currentCSV in PACKAGE_MANIFEST. | ||
| # This means you can run `./hack/update-metadata.sh` to update the manifests | ||
| # using the current package version, or you can for example run | ||
| # `./hack/update-metadata.sh 4.20` to set the package version to 4.20. | ||
| # Both PACKAGE_MANIFEST and CSV_MANIFEST will be updated by this script. |
There was a problem hiding this comment.
| # OCP_VERSION is an optional argument. If no argument is provided, it defaults | |
| # to the version found in .channels[0].currentCSV in PACKAGE_MANIFEST. | |
| # This means you can run `./hack/update-metadata.sh` to update the manifests | |
| # using the current package version, or you can for example run | |
| # `./hack/update-metadata.sh 4.20` to set the package version to 4.20. | |
| # Both PACKAGE_MANIFEST and CSV_MANIFEST will be updated by this script. | |
| # OCP_VERSION is an optional argument. | |
| # | |
| # If no argument is provided, the script defaults to the version found in the | |
| # '.channels[0].currentCSV' field of PACKAGE_MANIFEST. In this mode, only | |
| # CSV_MANIFEST is updated. This means you can run './hack/update-metadata.sh' | |
| # to update the manifest using the current package version. | |
| # | |
| # If you specify a version explicitly, for example './hack/update-metadata.sh 4.20', | |
| # the script will set the package version to '4.20' in both PACKAGE_MANIFEST | |
| # and CSV_MANIFEST. |
|
/lgtm |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/verified by CI runs |
openshift-ci-robot
added
the
verified
|
@radeore: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@rhrmo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/STOR-2600
/cc @openshift/storage
/cc @openshift/storage-qe