NE-2142: Bump golang to 1.24 #105
Conversation
This commit also replaces the CI golang images with public ones, similar to the operator repository. This change is supposed to prevent `registry-replacer` (https://github.com/openshift/ci-tools/tree/main/cmd/registry-replacer) from modifying the CI presubmit configuration of external-dns. `registry-replacer` regularly injects builder images into the external-dns CI configuration in `openshift/release` repository, but we want to maintain full control of that configuration directly from this source repository instead.
Golang 1.24 forces the use of constants for format strings. This PR updates `bluecat` and `vinyldns` providers code and unit test to conform with this new requirement.
Golang 1.24 forces the use of constants for format strings. This PR updates `tencentcloud` provider code to conform with this new requirement.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alebedev87: This pull request references NE-2142 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1.24This change is supposed to prevent
registry-replacer(https://github.com/openshift/ci-tools/tree/main/cmd/registry-replacer) from modifying the CI presubmit configuration of external-dns.registry-replacerregularly injects builder images into the external-dns CI configuration inopenshift/releaserepository, but we want to maintain full control of that configuration directly from this source repository instead. Related thread aboutregistry-replacer: link.1.24to use constant for format strings.