Skip to content

Conversation

jparrill
Copy link
Contributor

What this PR does / why we need it

OADP Operator has their own tests for testing the plugin integration. The plan is having those also here in order to allow verification before the image is published by Konflux

Ginkgo E2E tests

  • Followed same approach than oadp-operator repo
  • Added base tests
  • Added tests for None and Agent providers
  • Added tests for AWS and AKS
  • Enhanced Makefile target to have better verify coverage

Dependant PRs

  • Need to create a PR for Release repo to make this executable in every for presubmits
  • Check if we need periodics too

Which issue(s) this PR fixes

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2025

@jparrill: This pull request references CNTRLPLANE-1163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

What this PR does / why we need it

OADP Operator has their own tests for testing the plugin integration. The plan is having those also here in order to allow verification before the image is published by Konflux

Ginkgo E2E tests

  • Followed same approach than oadp-operator repo
  • Added base tests
  • Added tests for None and Agent providers
  • Added tests for AWS and AKS
  • Enhanced Makefile target to have better verify coverage

Dependant PRs

  • Need to create a PR for Release repo to make this executable in every for presubmits
  • Check if we need periodics too

Which issue(s) this PR fixes

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
Copy link

openshift-ci bot commented Jul 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants