[release-4.18] OCPBUGS-61773: UPSTREAM: <carry>: backporting fix for concurrent map iteration and write #2456 #2475
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@tjungblu: This pull request references Jira Issue OCPBUGS-61773, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tjungblu: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tjungblu: This pull request references Jira Issue OCPBUGS-61773, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.17 release-4.16 |
|
@tjungblu: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tjungblu: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
…d write Improve audit context handling by encapsulating event data and operations behind a structured API. Make the Audit system more robust in concurrent environments by properly isolating mutable state. The cleaner API simplifies interaction with audit events, improving maintainability. Encapsulation reduces bugs by preventing direct manipulation of audit events. Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Co-Authored-By: sxllwx <[email protected]>
tjungblu
force-pushed
the
OCPBUGS-61773
branch
from
e4d7269 to
db79b55
Compare
|
@tjungblu: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
Signed-off-by: Davanum Srinivas <[email protected]> Co-Authored-By: Jordan Liggitt <[email protected]> Co-Authored-By: Thomas Jungblut <[email protected]> Set event level during context init, fixing imports Signed-off-by: Davanum Srinivas <[email protected]> Signed-off-by: Thomas Jungblut <[email protected]>
… going to use it Merge pull request kubernetes#131725 from dims/avoid-encoding-in-log-response-object-when-we-dont-need-it
When backporting some changes from upstream's master branch a unit test ended up being broken. The code covered by this test does not seem to exist upstream, neither the test file. The code this commit fixes was introduced by 57c60d8 and we should squash this one with it once the time for rebasing arrives. Even though 57c60d8 description reads "UPSTREAM: 115328: annotate early and late requests" the upstream PR 115328 was closed without merging.
tjungblu
force-pushed
the
OCPBUGS-61773
branch
from
db79b55 to
fe126dd
Compare
|
@tjungblu: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
for future readers, there was only a conflict due to the rename in the import statements in We have squashed this into the same commit. |
|
/lgtm |
|
/remove-label backports/unvalidated-commits |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
removed
the
backports/unvalidated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required @wangke19 are you able to pre-merge verify this here too? as in #2456 (comment) |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@tjungblu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
manual cherry pick from #2456