Skip to content

[release-4.19] Backport StreamingCollectionEncoding for JSON and protobuf #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] Backport StreamingCollectionEncoding for JSON and protobuf #2478

wants to merge 8 commits into from

Conversation

rh-roman
Copy link

No description provided.

nkeert and others added 6 commits September 29, 2025 14:11
@nkeert @rh-roman
Add a test to validate deferredResponseWriteron multiple write calls
b384bea 
Signed-off-by: nkeert <[email protected]>
@z1cheng @rh-roman
Implement chunking for gzip encoder in deferredResponseWriter
e21380e 
Signed-off-by: z1cheng <[email protected]>
@serathius @rh-roman
Add tests for encoding collections in JSON for KEP-5116
3272991 
Used test cases from:
* Original PR kubernetes#129334
* KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5116-streaming-response-encoding#unit-tests

For now testing current serializer implementation to show encoder
behavior and agree on set of tests. Having a separate PR should make review easier.
In separate PR will add the implementation for streaming that should
provide same response byte-to-byte.
@serathius @rh-roman
Streaming JSON encoder for List
dd5e49b
@z1cheng @rh-roman
Implement tests for encoding collections in Proto
583d3c7 
Signed-off-by: z1cheng <[email protected]>
@serathius @rh-roman
Implement streaming proto encoding
de99adb
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 29, 2025
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 29, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 29, 2025

Hi @rh-roman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 29, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-roman
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2025
@rh-roman
Use switch test to gofuzz
0a0e63a 
randfill isn't available in 4.19
@rh-roman
Make streaming collection encoding off by default
4cbb621 
Require an explicit opt in for special handling of collection encoding.
@openshift-ci-robot
Copy link

@rh-roman: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2025

@rh-roman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-crun-wasm 4cbb621 link true /test e2e-aws-crun-wasm
ci/prow/e2e-gcp 4cbb621 link true /test e2e-gcp
ci/prow/e2e-aws-ovn-fips 4cbb621 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-runc 4cbb621 link true /test e2e-aws-ovn-runc
ci/prow/verify 4cbb621 link true /test verify
ci/prow/e2e-aws-ovn-cgroupsv2 4cbb621 link true /test e2e-aws-ovn-cgroupsv2
ci/prow/okd-scos-e2e-aws-ovn 4cbb621 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 4cbb621 link true /test e2e-aws-ovn-serial
ci/prow/k8s-e2e-conformance-aws 4cbb621 link true /test k8s-e2e-conformance-aws
ci/prow/e2e-metal-ipi-ovn-ipv6 4cbb621 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/verify-commits 4cbb621 link true /test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@benluddy
Copy link

benluddy commented Oct 2, 2025

/retitle [release-4.19] Backport StreamingCollectionEncoding for JSON and protobuf

@openshift-ci openshift-ci bot changed the title Backport StreamingCollectionEncoding for JSON and protobuf [release-4.19] Backport StreamingCollectionEncoding for JSON and protobuf Oct 2, 2025
@rh-roman
Copy link
Author

rh-roman commented Oct 2, 2025

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview openshift/api#2517

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 2, 2025

@rh-roman: user rh-roman is not trusted for pull request #2478

@benluddy
Copy link

benluddy commented Oct 2, 2025

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview openshift/api#2517

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 2, 2025

@benluddy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@benluddy
Copy link

benluddy commented Oct 2, 2025

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview openshift/api#2517

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 2, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28fb66a0-9fca-11f0-9331-8f7b43dad041-0

@openshift-ci openshift-ci bot mentioned this pull request Oct 2, 2025
Open
@benluddy
Copy link

benluddy commented Oct 6, 2025

Out of curiosity: #2487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rh-roman @openshift-ci-robot @benluddy @nkeert @z1cheng @serathius