[release-4.18] Backport StreamingCollectionEncoding for JSON and protobuf #2483
Conversation
Signed-off-by: nkeert <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Used test cases from: * Original PR kubernetes#129334 * KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/5116-streaming-response-encoding#unit-tests For now testing current serializer implementation to show encoder behavior and agree on set of tests. Having a separate PR should make review easier. In separate PR will add the implementation for streaming that should provide same response byte-to-byte.
Signed-off-by: z1cheng <[email protected]>
randfill isn't available in 4.19
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@rh-roman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rh-roman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @rh-roman. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle [release-4.18] Backport StreamingCollectionEncoding for JSON and protobuf |
openshift-ci
bot
changed the title
No description provided.