Skip to content

Commit 087dfd7

Browse files
Merge pull request #465 from zhuje/horitzontalnav-incidents-backup
OU-594: [Incidents] UI is not embedded in the Alerting section
2 parents ec96b8e + 91d97ba commit 087dfd7

File tree

10 files changed

+1006
-337
lines changed

10 files changed

+1006
-337
lines changed

config/acm-alerting.patch.json

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@
2020
"properties": {
2121
"exact": false,
2222
"path": [
23-
"/multicloud/monitoring/alerts",
24-
"/multicloud/monitoring/silences",
25-
"/multicloud/monitoring/alertrules"
23+
"/multicloud/monitoring"
2624
],
2725
"component": { "$codeRef": "AlertingPage" }
2826
}
@@ -88,22 +86,6 @@
8886
}
8987
}
9088
},
91-
{
92-
"op": "add",
93-
"path": "/extensions/1",
94-
"value": {
95-
"type": "console.page/route",
96-
"properties": {
97-
"exact": false,
98-
"path": [
99-
"/multicloud/monitoring/alerts",
100-
"/multicloud/monitoring/silences",
101-
"/multicloud/monitoring/alertrules"
102-
],
103-
"component": { "$codeRef": "AlertingPage" }
104-
}
105-
}
106-
},
10789
{
10890
"op": "add",
10991
"path": "/extensions/1",

config/incidents.patch.json

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,14 @@
33
"op": "add",
44
"path": "/extensions/1",
55
"value": {
6-
"type": "console.page/route",
6+
"type": "console.tab",
77
"properties": {
8-
"exact": false,
9-
"path": "/monitoring/incidents",
10-
"component": { "$codeRef": "IncidentsPage" }
11-
}
12-
}
13-
},
14-
{
15-
"op": "add",
16-
"path": "/extensions/1",
17-
"value": {
18-
"type": "console.navigation/href",
19-
"flags": {
20-
"required": ["PROMETHEUS", "MONITORING", "CAN_GET_NS"]
21-
},
22-
"properties": {
23-
"id": "incidents",
8+
"contextId": "admin-alerts-nav",
249
"name": "%plugin__monitoring-console-plugin~Incidents%",
25-
"href": "/monitoring/incidents",
26-
"perspective": "admin",
27-
"section": "observe",
28-
"insertAfter": "targets"
10+
"href": "incidents",
11+
"component": {
12+
"$codeRef": "IncidentsPage"
13+
}
2914
}
3015
}
3116
}

web/console-extensions.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181
"type": "console.page/route",
182182
"properties": {
183183
"exact": false,
184-
"path": ["/monitoring/alerts", "/monitoring/silences", "/monitoring/alertrules"],
184+
"path": "/monitoring",
185185
"component": { "$codeRef": "AlertingPage" }
186186
}
187187
},
@@ -262,9 +262,7 @@
262262
"properties": {
263263
"exact": false,
264264
"path": [
265-
"/virt-monitoring/alerts",
266-
"/virt-monitoring/silences",
267-
"/virt-monitoring/alertrules"
265+
"/virt-monitoring"
268266
],
269267
"component": { "$codeRef": "AlertingPage" }
270268
}

0 commit comments

Comments
 (0)