Skip to content

Conversation

zhuje
Copy link
Contributor

@zhuje zhuje commented Jul 16, 2025

JIRA

https://issues.redhat.com/browse/OU-594

Notes

This PR will only work if the Cluster Monitoring Operator and Monitoring Plugin are installed and viewed in the Administrator perspective.

Screen Capture

Screen.Recording.2025-07-16.at.1.11.54.AM.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

@zhuje: This pull request references OU-594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-594

Screen Capture

Screen.Recording.2025-07-16.at.12.26.29.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from etmurasaki and kyoto July 16, 2025 04:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

@zhuje: This pull request references OU-594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-594

Screen Capture

Screen.Recording.2025-07-16.at.1.11.54.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

@zhuje @etmurasaki we need to test this also when there is no MCO in the cluster.

@zhuje
Copy link
Contributor Author

zhuje commented Jul 17, 2025

/hold

Hold until this PR is merged NO-JIRA: Convert incidents to typescript then rebase.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

@zhuje: This pull request references OU-594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-594

Notes

This PR will only work if the Cluster Monitoring Operator and Monitoring Plugin are installed and viewed in the Administrator perspective.

Screen Capture

Screen.Recording.2025-07-16.at.1.11.54.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhuje
Copy link
Contributor Author

zhuje commented Jul 20, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2025
@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@etmurasaki
Copy link
Contributor

/label qe-approved
tested after Peter's fixes on:

  • Virtualization was showing Incidents tab and it shouldn't
  • Alerting pages on Virtualization, ACM were not working correctly
    It is working fine

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2025

@zhuje: This pull request references OU-594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-594

Notes

This PR will only work if the Cluster Monitoring Operator and Monitoring Plugin are installed and viewed in the Administrator perspective.

Screen Capture

Screen.Recording.2025-07-16.at.1.11.54.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor

/label ux-approved
This change was driven by UX

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Jul 22, 2025
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@zhuje: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 087dfd7 into openshift:main Jul 23, 2025
10 checks passed
@jgbernalp
Copy link
Contributor

/cherry-pick release-coo-0.5

@openshift-cherrypick-robot

@jgbernalp: #465 failed to apply on top of branch "release-coo-0.5":

Applying: use HoritzontalNav for Observe > Alerting Tabs so we can inject incidents
Using index info to reconstruct a base tree...
M	web/package-lock.json
M	web/package.json
M	web/src/components/MetricsPage.tsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/components/MetricsPage.tsx
Auto-merging web/package.json
Auto-merging web/package-lock.json
CONFLICT (content): Merge conflict in web/package-lock.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 use HoritzontalNav for Observe > Alerting Tabs so we can inject incidents

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgbernalp
Copy link
Contributor

/cherry-pick release-4.19

@openshift-cherrypick-robot

@jgbernalp: #465 failed to apply on top of branch "release-4.19":

Applying: use HoritzontalNav for Observe > Alerting Tabs so we can inject incidents
Using index info to reconstruct a base tree...
M	web/package-lock.json
M	web/package.json
M	web/src/components/Incidents/IncidentsPage.jsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/components/Incidents/IncidentsPage.jsx
CONFLICT (content): Merge conflict in web/src/components/Incidents/IncidentsPage.jsx
Auto-merging web/package.json
Auto-merging web/package-lock.json
CONFLICT (content): Merge conflict in web/package-lock.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 use HoritzontalNav for Observe > Alerting Tabs so we can inject incidents

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: monitoring-plugin
This PR has been included in build monitoring-plugin-container-v4.20.0-202507230546.p0.g087dfd7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants