Skip to content

Conversation

jgbernalp
Copy link
Contributor

No description provided.

@jgbernalp jgbernalp requested a review from PeterYurkovich July 23, 2025 06:41
@openshift-ci-robot
Copy link

@jgbernalp: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2025
@jgbernalp
Copy link
Contributor Author

/cherry-pick release-coo-0.5

@openshift-cherrypick-robot

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested a review from kyoto July 23, 2025 06:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@jgbernalp
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@jgbernalp
Copy link
Contributor Author

/label ux-approved
no ux changes

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Jul 23, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2025
@etmurasaki
Copy link
Contributor

As I had commented in https://issues.redhat.com/browse/OU-952, with this code I couldn't see incidents in the charts, while removing it from the env, I could see them.

@jgbernalp jgbernalp force-pushed the refactor-incidents-to-typescript branch from 36ae235 to 94891eb Compare August 5, 2025 10:11
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki
Copy link
Contributor

/label qe-approved
image
incidents are shown and links are redirecting correctly, silencing an alert as well.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 5, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b44de47 and 2 for PR HEAD 94891eb in total

@PeterYurkovich
Copy link
Contributor

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 1bb9c36 into openshift:main Aug 5, 2025
8 of 10 checks passed
@openshift-cherrypick-robot

@jgbernalp: #475 failed to apply on top of branch "release-coo-0.5":

Applying: refactor incidents to add typescript
.git/rebase-apply/patch:270: trailing whitespace.
                    Incident ID: 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	web/src/components/console/utils/units.js
Falling back to patching base and 3-way merge...
Auto-merging web/src/components/console/utils/units.ts
CONFLICT (content): Merge conflict in web/src/components/console/utils/units.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 refactor incidents to add typescript

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 94891eb link false /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: monitoring-plugin
This PR has been included in build monitoring-plugin-container-v4.20.0-202508052309.p0.g1bb9c36.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants