Skip to content

Conversation

jgbernalp
Copy link
Contributor

This PR adds the alerting rule tab to the dev console, to allow filtering of "Not Firing" alerts, which in principle are alerting rules.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2025
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-55455, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds the alerting rule tab to the dev console, to allow filtering of "Not Firing" alerts, which in principle are alerting rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from etmurasaki August 4, 2025 09:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@jgbernalp jgbernalp force-pushed the add-alertingrules-to-dev-console branch from c587a0e to 36c699b Compare August 4, 2025 09:06
@jgbernalp jgbernalp force-pushed the add-alertingrules-to-dev-console branch from 36c699b to d6c5c6c Compare August 4, 2025 12:41
@PeterYurkovich
Copy link
Contributor

/lgtm

Of note this will mostly be overridden by #483 on the 4.20 branch going forward, but I think it makes sense to merge these changes in and then rebase the other PR ontop of it to keep the same git history for the 4.20-4.X branches

@PeterYurkovich
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2025
@openshift-ci-robot
Copy link

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-55455, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak August 4, 2025 13:13
@PeterYurkovich
Copy link
Contributor

/label ux-approved
Solution was discussed with UX and approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Aug 4, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2025
Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

@jgbernalp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade d6c5c6c link false /test e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn d6c5c6c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@etmurasaki
Copy link
Contributor

/label qe-approved
testing scenarios added to jira

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 4, 2025
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-55455, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR adds the alerting rule tab to the dev console, to allow filtering of "Not Firing" alerts, which in principle are alerting rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 4, 2025
@etmurasaki
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 4, 2025
@openshift-ci-robot
Copy link

@etmurasaki: This pull request references Jira Issue OCPBUGS-55455, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @etmurasaki

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b44de47 into openshift:main Aug 5, 2025
8 of 10 checks passed
@openshift-ci-robot
Copy link

@jgbernalp: Jira Issue OCPBUGS-55455: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55455 has been moved to the MODIFIED state.

In response to this:

This PR adds the alerting rule tab to the dev console, to allow filtering of "Not Firing" alerts, which in principle are alerting rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: monitoring-plugin
This PR has been included in build monitoring-plugin-container-v4.20.0-202508050149.p0.gb44de47.assembly.stream.el9.
All builds following this will include this PR.

@jgbernalp
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

@jgbernalp: new pull request created: #488

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants