NO-JIRA: Allow multiple attempts in egress firewall test #29615
Conversation
openshift-merge-robot
added
the
needs-rebase
|
CC: @neisw @bertinatto could you please take a look at this? Should I rebase or simply wait for a review? |
|
Hi @ldoktor, go ahead and rebase. Typically you would get a review from the team responsible for the test (looks like sdn team). Also if you know of a job that typically shows this failure it would be good to run that job for validation along with the regular presubmits. |
this test is failing when using kata-containers, which might be related
to longer startup times of kata-containers:
curl: (28) Connection timed out after 1001 milliseconds
let's use the "--retry" feature of curl. This should not affect the
successful tests as they should return immediately, while it might
prolong the failing tests from 3s to 30s. With kata we need about 6-12s
so 30s should be safe for us.
Signed-off-by: Lukáš Doktor <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
Thank you, I wasn't sure. It's rebased, the failed job log is here: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-kata-containers-kata-containers-main-e2e-tests/1903703902650372096 and I manually tested my code with extra debug, usually it's 3-4 retries before it's ready and the test is passing with this exact commit as well. |
|
/payload-job periodic-ci-kata-containers-kata-containers-main-e2e-tests |
|
@neisw: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
No luck running |
This is related to upstream testing so we don't have any jira for it. |
|
/lgtm you probably want to retitle with NO-JIRA: then |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldoktor, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ldoktor
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@ldoktor: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2 similar comments
1 similar comment
1 similar comment
|
/hold Revision c0e7f89 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
Hello folks, the only required test https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29615/pull-ci-openshift-origin-main-e2e-aws-ovn-serial/1914323994480218112 failed with which is a different test than the one I'm touching. How should I proceed to get this little improvement merged? |
|
@ldoktor: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: c0e7f89
|
this test is failing when using kata-containers, which might be related to longer startup times of kata-containers:
let's use the "--retry" feature of curl. This should not affect the successful tests as they should return immediately, while it might prolong the failing tests from 3s to 30s. With kata we need about 6-12s so 30s should be safe for us.