-
Notifications
You must be signed in to change notification settings - Fork 4.7k
NO-JIRA: Pass the port to internal LB deployment in monitoring tests #29711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The .status.apiServerInternalURI of Infrastructure might contain a port (for example https://api.d560406ce00e8ae40e77.hypershift.local:443) In this case the port must be passed to the deployment as the default port 6443 will not work.
@mgencur: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/assign @vrutkovs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur, vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
@mgencur: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 1f75cda
|
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0
…WS (#63982) * CNTRLPLANE-706 Build CI to cover Calico CNI test for private HCP on AWS Exclude the following tests: * Test name: The default cluster RBAC policy should have correct RBAC rules Reason: The test fails as it finds unexpected RBACs from Calico. * Test name: Cluster scoped load balancer healthcheck port and path should be 10256/healthz Reason: Reported https://issues.redhat.com/browse/CNTRLPLANE-788. It's a valid bug in HCP * Test name: Prometheus [apigroup:image.openshift.io] when installed on the cluster should provide named network metrics Reason: Reported projectcalico/calico#10351 against Calico (seem to be breaking the spec) * Test name: Unidling* Reason: Feature not implemented in Calico. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.IFNAME.arp_filter Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: pod should not start for sysctls not on whitelist [apigroup:k8s.cni.cncf.io] net.ipv4.conf.all.send_redirects Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Test name: sysctl allowlist update should start a pod with custom sysctl only when the sysctl is added to whitelist sysctl is added to whitelist Reason: Calico doesn’t validate sysctl conf against the "allowlist.conf". It has its own way. * Disable monitoring test apiserver-incluster-availability Reason: The test reads the KAS URL from .status.apiServerInternalURI of Infrastructure resource named "cluster" but that is in the form of https://api.d560406ce00e8ae40e77.hypershift.local:443 in the hosted cluster and is not reachable. See openshift/origin#29711 More details in https://docs.google.com/document/d/19lYcivp3eRcQQjhDssZnY89nKM_RG84TyVGCeIk5keA/edit?tab=t.0 * Move Calico folder under hypershift/private/guest
The .status.apiServerInternalURI of Infrastructure might contain a port (for example https://api.d560406ce00e8ae40e77.hypershift.local:443) In this case the port must be passed to the deployment as the default port 6443 will not work.
We ran into this issue when testing Hypershift with
--endpoint-access=private
and external DNS. In this case the port is 443. The test[Jira: "kube-apiserver"] can collect apiserver.openshift.io/disruption-actor=poller poller pod logs
failed in this run, the error was: