Skip to content

MCO-1797: Fix transient errors while checking status of PIS #29962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RishabhSaini
Copy link
Contributor

pinnedimages: Do not fail prematurely in waitForStatusX

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2025

@RishabhSaini: This pull request references MCO-1797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

pinnedimages: Do not fail prematurely in waitForStatusX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@isabella-janssen
Copy link
Member

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-serial-ovn-ipv4-techpreview-1of2 periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-serial-ovn-ipv4-techpreview-2of2

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@isabella-janssen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@isabella-janssen
Copy link
Member

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-techpreview-serial 5

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d1372040-5b44-11f0-8531-db8abe00f5ad-0

@isabella-janssen
Copy link
Member

isabella-janssen commented Jul 8, 2025

/lgtm

The test runs look to have been successful. Since the issue addressed by MCO-1797 is intermittent, the best way to understand the true success of this fix will be to actively monitor the Invalid PIS leads to degraded MCN in a standard Pool test for a while.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
Copy link
Contributor

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f380d1e and 2 for PR HEAD 226429e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9b1fca and 1 for PR HEAD 226429e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9b1fca and 2 for PR HEAD 226429e in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9b1fca and 2 for PR HEAD 226429e in total

Copy link

openshift-trt bot commented Jul 8, 2025

Job Failure Risk Analysis for sha: 226429e

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (22) are below the historical average (1736): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7e27b2b and 1 for PR HEAD 226429e in total

Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@RishabhSaini: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants