Skip to content

Conversation

hongkailiu
Copy link
Member

Revert #30313 with an exception OCPBUGS-62517 for co/olm.

/hold

Let us run the aggregated job to avoid breaking payload again.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2025
@openshift-ci-robot
Copy link

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

Revert #30313 with an exception OCPBUGS-62517 for co/olm.

/hold

Let us run the aggregated job to avoid breaking payload again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade 10

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2025
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/540d86b0-9e45-11f0-9776-b23ad404be06-0

@hongkailiu
Copy link
Member Author

/payload-abort

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: aborted active payload jobs for pull request #30325

@hongkailiu
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade #30296

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/013427e0-9e46-11f0-90a3-59eae64d5fbf-0

@hongkailiu
Copy link
Member Author

/payload-abort

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: aborted active payload jobs for pull request #30325

@hongkailiu
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade #30325

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/559828e0-9e46-11f0-9b39-c2a961558e89-0

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@hongkailiu: This PR was included in a payload test run from #30325
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/559828e0-9e46-11f0-9b39-c2a961558e89-0

@neisw
Copy link
Contributor

neisw commented Sep 30, 2025

Just a note, you should be able to use /payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade if this is the only pr you are testing with.

Looks like with-prs form is working too.

@hongkailiu
Copy link
Member Author

hongkailiu commented Oct 1, 2025

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/openshift-origin-30325-openshift-origin-30325-ci-4.21-e2e-gcp-ovn-upgrade/1973141385175371776/artifacts/e2e-gcp-ovn-upgrade/openshift-e2e-test/artifacts/junit/e2e-monitor-tests__20250930-230318.xml | grep 'clusteroperator/olm should not change condition/Available' -A1
    <testcase name="[Monitor:legacy-cvo-invariants][bz-OLM] clusteroperator/olm should not change condition/Available" time="0"></testcase>
    <testcase name="[Monitor:legacy-cvo-invariants][bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available" time="0"></testcase>

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade 10 #30325

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/83469f20-9eb8-11f0-8f1a-f587326a89b0-0

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: This PR was included in a payload test run from #30325
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/83469f20-9eb8-11f0-8f1a-f587326a89b0-0

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3baa4bc0-9eb9-11f0-899b-564241c76315-0

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: This PR was included in a payload test run from #30325
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3baa4bc0-9eb9-11f0-899b-564241c76315-0

@hongkailiu
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade #30325

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e4092bb0-9eb9-11f0-9dc3-c3f81916b8a9-0

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: This PR was included in a payload test run from #30325
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e4092bb0-9eb9-11f0-9dc3-c3f81916b8a9-0

@hongkailiu
Copy link
Member Author

With this pull which adds Available=False with reason=KubeStorageVersionMigrator_Deploying as an exception for co/olm, we must not see any failure on "clusteroperator/olm should not change condition/Available" like this one without this pull.

Moreover, if the exception indeed happens in the test, the test case flakes.

@hongkailiu hongkailiu force-pushed the revert-aca74c4009a1e252f37e8b563ead0bbb6b61c1ad branch from 4c087ef to 558fc12 Compare October 1, 2025 19:38
@hongkailiu
Copy link
Member Author

/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade 10 #30325

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/556fafb0-9efe-11f0-8d65-49bc1fad1093-0

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@hongkailiu: This PR was included in a payload test run from #30325
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/556fafb0-9efe-11f0-8d65-49bc1fad1093-0

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@neisw
Copy link
Contributor

neisw commented Oct 1, 2025

So far it doesn't look like any of the jobs have been successful upgrading. That shouldn't be because of this PR but I'm wondering about the 'with-prs' command in this case. Waiting on the current aggregate run to finish assuming it shows the same results will try with

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade 10

@neisw
Copy link
Contributor

neisw commented Oct 2, 2025

/approve

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30325-openshift-origin-30325-ci-4.21-e2e-gcp-ovn-upgrade/1973472870411538432

looks good with

0 unexpected clusteroperator state transitions during e2e test run, as desired.
9 unwelcome but acceptable clusteroperator state transitions during e2e test run.  These should not happen, but because they are tied to exceptions, the fact that they did happen is not sufficient to cause this test-case to fail:

Oct 01 22:17:44.468 E clusteroperator/olm condition/Available reason/CatalogdDeploymentCatalogdControllerManager_Deploying status/False CatalogdDeploymentCatalogdControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:17:44.468 - 44s   E clusteroperator/olm condition/Available reason/CatalogdDeploymentCatalogdControllerManager_Deploying status/False CatalogdDeploymentCatalogdControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:18:28.960 W clusteroperator/olm condition/Available reason/AsExpected status/True CatalogdDeploymentCatalogdControllerManagerAvailable: Deployment is available\nOperatorcontrollerDeploymentOperatorControllerControllerManagerAvailable: Deployment is available (exception: Available=True is the happy case)
Oct 01 22:26:34.153 E clusteroperator/olm condition/Available reason/OperatorcontrollerDeploymentOperatorControllerControllerManager_Deploying status/False OperatorcontrollerDeploymentOperatorControllerControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:26:34.153 - 16s   E clusteroperator/olm condition/Available reason/OperatorcontrollerDeploymentOperatorControllerControllerManager_Deploying status/False OperatorcontrollerDeploymentOperatorControllerControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:26:50.285 W clusteroperator/olm condition/Available reason/AsExpected status/True CatalogdDeploymentCatalogdControllerManagerAvailable: Deployment is available\nOperatorcontrollerDeploymentOperatorControllerControllerManagerAvailable: Deployment is available (exception: Available=True is the happy case)
Oct 01 22:34:48.397 E clusteroperator/olm condition/Available reason/CatalogdDeploymentCatalogdControllerManager_Deploying status/False CatalogdDeploymentCatalogdControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:34:48.397 - 22s   E clusteroperator/olm condition/Available reason/CatalogdDeploymentCatalogdControllerManager_Deploying status/False CatalogdDeploymentCatalogdControllerManagerAvailable: Waiting for Deployment (exception: https://issues.redhat.com/browse/OCPBUGS-62517)
Oct 01 22:35:11.056 W clusteroperator/olm condition/Available reason/AsExpected status/True CatalogdDeploymentCatalogdControllerManagerAvailable: Deployment is available\nOperatorcontrollerDeploymentOperatorControllerControllerManagerAvailable: Deployment is available (exception: Available=True is the happy case)

Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, neisw, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025
@hongkailiu
Copy link
Member Author

/verified by aggregator-periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 2, 2025
@openshift-ci-robot
Copy link

@hongkailiu: This PR has been marked as verified by aggregator-periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade.

In response to this:

/verified by aggregator-periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af977aa and 2 for PR HEAD 558fc12 in total

Copy link

openshift-trt bot commented Oct 2, 2025

Job Failure Risk Analysis for sha: 558fc12

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (145) are below the historical average (1258): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade Low
Job run should complete before timeout
This test has passed 77.70% of 5349 runs on release 4.21 [Overall] in the last week.
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (140) are below the historical average (1800): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Copy link

openshift-trt bot commented Oct 2, 2025

Job Failure Risk Analysis for sha: 558fc12

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (145) are below the historical average (1258): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade Low
Job run should complete before timeout
This test has passed 77.70% of 5349 runs on release 4.21 [Overall] in the last week.
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn IncompleteTests
Tests for this run (140) are below the historical average (1789): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@hongkailiu
Copy link
Member Author

/test e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ded19e into openshift:main Oct 3, 2025
23 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants