OCPBUGS-62264: vSphere snapshot options test should wait for operator to settle #30336
Conversation
openshift-ci-robot
added
jira/severity-important
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-62264, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RomanBednar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@RomanBednar: This pull request references Jira Issue OCPBUGS-62264, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial |
|
@RomanBednar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/650dd560-a03d-11f0-9b26-9d92c77dd6e8-0 |
|
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test help |
|
@jsafrane: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial |
|
@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c38b5a20-a292-11f0-9c93-98188bb0b34c-0 |
| err := util.WaitForOperatorProgressingFalse(ctx, oc.AdminConfigClient(), providerName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) |
There was a problem hiding this comment.
providerName is csi.vsphere.vmware.com and WaitForOperatorProgressingFalse tries to read ClusterOperator with this name... Do I miss anything?!
| // Wait for operator to be Progressing=False to ensure all pod creation events complete before test ends. | ||
| // This allows the pathological event matcher (newVsphereConfigurationTestsRollOutTooOftenEventMatcher in | ||
| // pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go) to accurately attribute | ||
| // pod events to this test's time window (interval); any events emitted later would not be matched. | ||
| err := util.WaitForOperatorProgressingFalse(ctx, oc.AdminConfigClient(), providerName) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) |
There was a problem hiding this comment.
This whole chunk belongs to AfterEach, where the original configuration is restored. We should ensure that events produced by that are counted within the test interval too.
| // This allows the pathological event matcher (newVsphereConfigurationTestsRollOutTooOftenEventMatcher in | ||
| // pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go) to accurately attribute | ||
| // pod events to this test's time window (interval); any events emitted later would not be matched. | ||
| err := util.WaitForOperatorProgressingFalse(ctx, oc.AdminConfigClient(), providerName) |
There was a problem hiding this comment.
Can WaitForOperatorProgressingFalse() observe the ClusterOperator as not progressing before the CSI driver operator has even chance to see the new config and act on it?
No description provided.