OCPBUGS-86017: Extend image-registry single replica exception to s390x architecture#31190
OCPBUGS-86017: Extend image-registry single replica exception to s390x architecture#31190ropatil010 wants to merge 2 commits into
Conversation
This commit extends the existing ppc64le single-replica image-registry exception to also cover s390x architecture. During upgrades from 4.22 to 5.0, clusters running on s390x with a single replica image-registry deployment experience temporary unavailability (NoReplicasAvailable) when the registry pod is restarted. This is a known limitation on alternative architectures due to the lack of redundancy with a single replica. Changes: - Replaced isppc64le() function with getAltArchitecture() to support multiple alternative architectures (ppc64le and s390x) - Added s390x exception with bug ID OCPBUGS-86017 - Updated exception handling to use a switch statement for clarity - Improved logging to include the detected architecture - Used platformidentification constants for architecture names Bug: https://redhat.atlassian.net/browse/OCPBUGS-86017 Related: https://redhat.atlassian.net/browse/OCPBUGS-82160 (ppc64le) Co-Authored-By: Rohit Patil <ropatil@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@ropatil010: This pull request references Jira Issue OCPBUGS-86017, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: ropatil010. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds a getArchitecture helper that lists cluster Nodes to detect ChangesImage-registry upgrade exception handling
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@ropatil010: This pull request references Jira Issue OCPBUGS-86017, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: ropatil010. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @KeerthanaAP @prb112 |
|
/pipeline required |
|
Scheduling required tests: |
|
/retest-required |
|
/lgtm |
|
@ropatil010: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/924454b0-5365-11f1-9b50-523cf28a3f02-0 |
|
@ropatil010: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bdac2b60-538c-11f1-98c3-a465ddd91667-0 |
|
@ropatil010: This pull request references Jira Issue OCPBUGS-86017, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/retest |
|
The failure profile pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 is not related to this PR changes. We can retry this as re-run if needed |
|
Job Failure Risk Analysis for sha: b8c4def
|
|
/test e2e-aws-ovn-serial-2of2 |
|
@ropatil010: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi @prb112 PTAL on the PR. Thanks in adv! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KeerthanaAP, prb112, ropatil010 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @deads2k @p0lyn0mial |
|
@ropatil010: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eab50df0-551e-11f1-8bf8-de0ed655e90b-0 |
|
@ropatil010: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74abfb50-5587-11f1-891d-81570b276bf2-0 |
|
/payload-job periodic-ci-openshift-multiarch-main-nightly-5.0-upgrade-from-nightly-4.22-ocp-ovn-remote-libvirt-multi-z-z |
|
@ropatil010: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95859cb0-5739-11f1-8092-9205cf670d0a-0 |
Hi Team,
Can you PTAL on this PR.
This commit extends the existing ppc64le single-replica image-registry exception to also cover s390x architecture. During upgrades from 4.22 to 5.0, clusters running on s390x with a single replica image-registry deployment experience temporary unavailability (NoReplicasAvailable) when the registry pod is restarted. This is a known limitation on alternative architectures due to the lack of redundancy with a single replica.
Changes:
Bug: https://redhat.atlassian.net/browse/OCPBUGS-86017
Related: https://redhat.atlassian.net/browse/OCPBUGS-82160 (ppc64le)
Summary by CodeRabbit