Skip to content

NO-JIRA: Use different branch prefix for mintmaker updates #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Use different branch prefix for mintmaker updates #102

wants to merge 1 commit into from

Conversation

yuumasato
Copy link

As we are using konlux branch to pull upload changes from upstream, we need to use a different branch for mintmaker.

@rhmdnd
Copy link

rhmdnd commented Sep 4, 2025

Do we need to make this change to the konflux branch so that it's picked up by mintmaker?

@rhmdnd
Copy link

rhmdnd commented Sep 4, 2025

Do we need to make this change to the konflux branch so that it's picked up by mintmaker?

Disregard, looks like this needs to be made to the main branch.

rhmdnd
rhmdnd approved these changes Sep 5, 2025
View reviewed changes
Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@rhmdnd
Copy link

rhmdnd commented Sep 5, 2025

/retest-required

@yuumasato yuumasato force-pushed the change-mintmaker-prefix-branch branch from 3cb1c9a to f720adf Compare September 5, 2025 08:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@rhmdnd
Copy link

rhmdnd commented Sep 5, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 5, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2025
@yuumasato
Use different branch prefix for mintmaker updates
a6e0a3f 
As we are using konflux branch to pull changes from upstream, we
need to use a different branch for mintmaker.
This update the schedule too, so that it doesn't just run on weekends.
@yuumasato yuumasato force-pushed the change-mintmaker-prefix-branch branch from f720adf to a6e0a3f Compare September 5, 2025 22:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@yuumasato
Copy link
Author

I have added tekton specific configs too.

rhmdnd
rhmdnd approved these changes Sep 8, 2025
View reviewed changes
Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, saschagrunert, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato yuumasato changed the title Use different branch prefix for mintmaker updates NO-JIRA: Use different branch prefix for mintmaker updates Sep 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2025
@openshift-ci-robot
Copy link

@yuumasato: This pull request explicitly references no jira issue.

In response to this:

As we are using konlux branch to pull upload changes from upstream, we need to use a different branch for mintmaker.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiaojiey
Copy link

xiaojiey commented Sep 9, 2025

/label qe-approval

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 9, 2025

@xiaojiey: The label(s) /label qe-approval cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label qe-approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xiaojiey
Copy link

xiaojiey commented Sep 9, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 9, 2025
@xiaojiey
Copy link

xiaojiey commented Sep 9, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

+1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@saschagrunert saschagrunert

@rhmdnd rhmdnd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuumasato @rhmdnd @openshift-ci-robot @xiaojiey @saschagrunert