Skip to content

Sample Memcached added. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2021
Merged

Sample Memcached added. #7

merged 4 commits into from
Apr 30, 2021

Conversation

laxmikantbpandhare
Copy link
Member

No description provided.

@jmrodri
Copy link
Member

jmrodri commented Apr 29, 2021

@laxmikantbpandhare what if we move the sample to the testdata like we do in the SDK? Then we can use it in tests we write in the future. Maybe put them in testdata/quarkus.

@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare what if we move the sample to the testdata like we do in the SDK? Then we can use it in tests we write in the future. Maybe put them in testdata/quarkus.

Yes, we can.

jmrodri
jmrodri approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@jmrodri jmrodri merged commit 1e3ddb2 into operator-framework:main Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@jmrodri jmrodri

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laxmikantbpandhare @jmrodri @openshift-ci-robot