Skip to content

fix: javadoc for fails snapshot release #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix: javadoc for fails snapshot release #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...vaoperatorsdk/operator/processing/dependent/external/AbstractSimpleDependentResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ public Optional<R> getResource(HasMetadata primaryResource) {
return cache.get(ResourceID.fromResource(primaryResource));
}

/** Actually read the resource from the target API */
/**
* Actually read the resource from the target API
*
* @param primaryResource the primary associated resource
* @return fetched resource if present
**/
public abstract Optional<R> fetchResource(HasMetadata primaryResource);

@Override
Expand Down
3 changes: 1 addition & 2 deletions ...java/io/javaoperatorsdk/operator/processing/event/ExternalResourceCachingEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
import io.javaoperatorsdk.operator.processing.event.source.CachingEventSource;

public class ExternalResourceCachingEventSource<R, P extends HasMetadata>
extends CachingEventSource<R, P>
implements RecentOperationCacheFiller<R> {
extends CachingEventSource<R, P> implements RecentOperationCacheFiller<R> {

public ExternalResourceCachingEventSource(Class<R> resourceClass) {
super(resourceClass);
Expand Down
6 changes: 0 additions & 6 deletions ...src/main/java/io/javaoperatorsdk/operator/processing/event/source/CachingEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@
/**
* Base class for event sources with caching capabilities.
* <p>
* {@link #handleDelete(ResourceID)} - if the related resource is present in the cache it is removed
* and event propagated. There is no event propagated if the resource is not in the cache.
* <p>
* {@link #handleEvent(Object, ResourceID)} - caches the resource if changed or missing. Propagates
* an event if the resource is new or not equals to the one in the cache, and if accepted by the
* filter if one is present.
*
* @param <R> represents the type of resources (usually external non-kubernetes ones) being handled.
*/
Expand Down